feat: Improve web-ui for listing of repositories #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch by repo name and viewing ports and type of presented repos. Add signout.
|
@olenagerasimova Please review |
olenagerasimova
requested changes
Nov 14, 2022
Comment on lines
51
to
55
| /** | ||
| * Obtain Artipie layout. | ||
| * @return Artipie layout | ||
| */ | ||
| public int port() { |
| /** | ||
| * Repository name. | ||
| */ | ||
| @SuppressWarnings("PMD.AvoidFieldNameMatchingMethodName") |
There was a problem hiding this comment.
hm, one suppression on class level should be enough
There was a problem hiding this comment.
@andpopov what about this one? Is qulice still complaining if you move @SuppressWarnings("PMD.AvoidFieldNameMatchingMethodName") to Repo class declaration and remove suppressions under the fields?
There was a problem hiding this comment.
qulice works correctly, fixed.
Thanks
|
@olenagerasimova Thanks a lot, fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #101
Improve web-ui for listing of repositories with support of search by repo name and viewing ports and type of presented repos.
Add signout.