Implemented RpmMetadata.Append
#405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olenagerasimova
requested review from
a team and
genryxy
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #405 +/- ##
============================================
+ Coverage 85.90% 86.00% +0.10%
Complexity 303 303
============================================
Files 55 55
Lines 1752 1772 +20
Branches 99 103 +4
============================================
+ Hits 1505 1524 +19
+ Misses 232 230 -2
- Partials 15 18 +3
Continue to review full report at Codecov.
|
genryxy
reviewed
May 20, 2021
Comment on lines
+44
to
+46
|
|
||
| @Test | ||
| void appendsRecords() throws IOException { |
There was a problem hiding this comment.
@olenagerasimova thanks. Is it possible to add packages when primary.xml.example and other.xml.example are empty or absent? If it is so, I'd suggest to add such test case
There was a problem hiding this comment.
@genryxy now - it's not possible, there will be an invalid xml exception or smth like that. But that's a good question, I will discuss such scenario with our colleagues and make the changes accordingly.
|
@rultor release, tag= |
@olenagerasimova OK, I will release it now. Please check the progress here |
@olenagerasimova Oops, I failed. You can see the full log here (spent 9min) |
|
@rultor release, tag= |
@olenagerasimova OK, I will release it now. Please check the progress here |
@olenagerasimova Oops, I failed. You can see the full log here (spent 10min) |
|
@rultor release, tag= |
@olenagerasimova OK, I will release it now. Please check the progress here |
@olenagerasimova Done! FYI, the full log is here (took me 10min) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #388
Implemented
RpmMetadata.Appendand added test.