Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused classes and tests #484

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Conversation

olenagerasimova
Copy link
Member

Part of #440
Cleaned up unused classes, tests and some code from used classes.

@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #484 (7aae84e) into master (92815b3) will increase coverage by 0.95%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #484      +/-   ##
============================================
+ Coverage     86.96%   87.91%   +0.95%     
+ Complexity      462      382      -80     
============================================
  Files            65       49      -16     
  Lines          2201     1639     -562     
  Branches        139      111      -28     
============================================
- Hits           1914     1441     -473     
+ Misses          263      179      -84     
+ Partials         24       19       -5     
Impacted Files Coverage Δ
src/main/java/com/artipie/rpm/meta/XmlPackage.java 94.73% <ø> (+12.91%) ⬆️
src/main/java/com/artipie/rpm/pkg/FilePackage.java 96.96% <ø> (-3.04%) ⬇️
src/main/java/com/artipie/rpm/NamingPolicy.java 80.00% <0.00%> (-20.00%) ⬇️
...ain/java/com/artipie/rpm/StandardNamingPolicy.java 81.81% <0.00%> (-18.19%) ⬇️
.../main/java/com/artipie/rpm/meta/XmlWriterWrap.java 29.68% <0.00%> (-12.50%) ⬇️
src/main/java/com/artipie/rpm/meta/XmlRepomd.java 81.96% <0.00%> (-1.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92815b3...7aae84e. Read the comment docs.

@olenagerasimova olenagerasimova requested review from a team and genryxy and removed request for a team November 15, 2021 15:23
Copy link
Contributor

@genryxy genryxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olenagerasimova thanks, looks good to me

@olenagerasimova olenagerasimova merged commit 2b797f9 into master Nov 16, 2021
@olenagerasimova olenagerasimova deleted the 440-remove-unused-classes branch November 16, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants