Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions fails to build the image #55

Merged
merged 12 commits into from
Apr 11, 2020
Merged

GitHub Actions fails to build the image #55

merged 12 commits into from
Apr 11, 2020

Conversation

artis3n
Copy link
Owner

@artis3n artis3n commented Apr 7, 2020

As of v2.2.0, GitHub Actions fails to build the image (see #54 ). This is reproducible in https://github.com/artis3n/test_issue_54/actions/runs/73053289.

  • Resolved this by reverting to COPY . . and adding a .dockerignore to keep out the files we don't want.

I also discovered a new issue (see this comment) which I believe is a bug in the GitHub Actions implementation. See this Community form issue I filed about this. It was immediately marked as spam and I'm not sure why that is, but hopefully my request to un-mark it as spam is accepted...

My temporary solution was to set an absolute path in the ENTRYPOINT, but I would expect that path to break if GitHub properly sets their WORKDIR. We'll see what happens.

@artis3n artis3n marked this pull request as ready for review April 7, 2020 21:53
@artis3n
Copy link
Owner Author

artis3n commented Apr 7, 2020

This appears to fix the issue in #54 but another issue appears:
image

Running docker build --no-cache -t test:1 . and then docker run -it --rm --entrypoint "/bin/bash" test:1 allow me to ls the container root and see that the expected files are present. This error seems to be some issue with how GitHub Actions handles containers.

image

@artis3n
Copy link
Owner Author

artis3n commented Apr 7, 2020

Moving the image to node:12-slim hasn't helped:

image

https://github.com/artis3n/test_issue_54/runs/569112656?check_suite_focus=true

@artis3n artis3n merged commit 30e26ea into master Apr 11, 2020
@artis3n artis3n deleted the issue-54 branch April 11, 2020 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant