Enumerated all fields explicitly for INSERT operation #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
After Clickhouse release 18.12.14 I noticed Clickhouse server crashes and reported them to Yandex: ClickHouse/ClickHouse#3141
Alexey Milovidov found issue and it was caused by different number of fields in table and number of fields in insert operation.
But that's my case because as suggested in https://github.com/artpaul/clickhouse-cpp/issues/38 I switched to "DEFAULT" value for single field and do not populate it from INSERT operation.
In this PR I added explicit enumeration for all fields to avoid such issue. After this fix, issue disappeared and Clickhouse serveк (18.12.17) did not crash anymore.
And insert operation looks like:
Thank you!