@craigspaeth: Link underlines should be compatible with newlines #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You could use a background image linear gradient, which is what force has mostly switched to doing: https://github.com/artsy/force/blob/1f56f84b151adf8cf276169a0387af6937ccc49c/components/stylus_lib/index.styl#L193-L198 (Might need some tweaking) |
|
👍 thanks! |
craigspaeth
added a commit
that referenced
this pull request
Sep 30, 2015
@craigspaeth: Link underlines should be compatible with newlines
|
Thanks @dzucconi. Now looks like:
This is ahem not obvious, so I anticipate weirdness. However, it seemed OK according to my quick check in Chrome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
border-bottomtrick to underline links looks bad when links wrap:Links wrap a lot, especially given the narrow content area. The default behavior looks slightly less bad:
...but still looks bad. I made the easy change, but I'd rather fix the underline thickness. Is that possible?