OSS FAQ for Engineers #303
Conversation
orta
commented
Jan 4, 2017
orta
commented
Proselint found issues_posts/2017-01-04-OSS-FAQ.md
Spell Checker found issues_posts/2017-01-04-OSS-FAQ.md
Generated by 🚫 danger |
| series: Open Source by Default | ||
| --- | ||
|
|
||
| We have a lot of Open Source code. For engineers without considerable experience in the open source realm, understanding some of the copyright issues around copyrights and code ownership can be tricky. I've been working with [dB](http://artsy.github.io/author/db/), our CTO and [Yayoi Shionoiri](http://www.theartgorgeous.com/yayoi-shionoiri/) (our Senior Counsel) on documenting how this works. |
There was a problem hiding this comment.
Link "open source code" to something, list of OSS projects or github.
There was a problem hiding this comment.
dB. is spelled with a period :) Also maybe flip "our CTO dB., and our senior counsel Yayoi...", I don't think senior counsel needs to be capitalized but I could be wrong.
There was a problem hiding this comment.
copyright issues around copyrights is redundant, remove "around copyrights"
There was a problem hiding this comment.
documenting how this works => maybe "creating an open-source FAQ for engineers"?
There was a problem hiding this comment.
Yeah, I agree with all of this 👍
|
|
||
| We have a lot of Open Source code. For engineers without considerable experience in the open source realm, understanding some of the copyright issues around copyrights and code ownership can be tricky. I've been working with [dB](http://artsy.github.io/author/db/), our CTO and [Yayoi Shionoiri](http://www.theartgorgeous.com/yayoi-shionoiri/) (our Senior Counsel) on documenting how this works. | ||
|
|
||
| I'd like to personally thank [Gil Yehuda](http://gilyehuda.strikingly.com) of Yahoo! for answering a lot of our questions, you really helped. For Artsy staff, you can get the living document at the [Engineering page on Artsy Atlas](https://sites.google.com/a/artsymail.com/intranet/team-pages/engineering). |
There was a problem hiding this comment.
This should be at the bottom of the post.
|
|
||
| <!-- more --> | ||
|
|
||
| ### What is Open Source “by default”? |
There was a problem hiding this comment.
Maybe link http://code.dblock.org/2015/02/09/becoming-open-source-by-default.html somewhere?
There was a problem hiding this comment.
Cool, good point, I've made the first mention of OSS by Default a link (its in the paragraph above )
|
Rock, all feedback addressed |
|
|
||
| Inbound Open Source code refers to the use of third party code under an Open Source license for Artsy's products. Outbound Open Source code refers to the publication of Artsy code. | ||
|
|
||
| When we publish Outbound Open Source code, as mentioned before, Artsy has a right to do so because we have the copyright to this code. We give third parties the right to use the code usually through [this type](https://github.com/artsy/eigen/blob/master/LICENSE) of broad license ([MIT](https://tldrlegal.com/license/mit-license)). (For more on code licenses, see [Orta’s talk on code licenses](http://artsy.github.io/blog/2015/12/10/License-and-You/.) |
There was a problem hiding this comment.
The period needs to be outside of the parenthesis, it's part of the sentence, not the link. The link here is broken.
|
Fix the link above and feel free to merge. Thanks. |
|
nice catch |
