Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lunrjs Search #332

Merged
merged 4 commits into from Mar 27, 2017
Merged

lunrjs Search #332

merged 4 commits into from Mar 27, 2017

Conversation

@ashfurrow
Copy link
Contributor

@ashfurrow ashfurrow commented Mar 25, 2017

Fixes #329

So we're using a fork of this library, because the library requires Jekyll 3 (as far as I can tell) and there are no semantic tags available to reference in our Gemfile. I added Jekyll 2-style posts, and there appeared to be some weirdness with emoji in Jekyll being index in lunr.js so I filtered them out of the index in the first way that Google suggested which looks terrible but works.

The design needs a little work for sure. Here's a before/after shot:

screen shot 2017-03-25 at 7 29 31 pm
screen shot 2017-03-25 at 7 28 40 pm

The downside compared to Google Site search is that we don't get a preview of the post, due to limitations in lunr.js. I think that's okay, but wanted to surface it for discussion.

@orta
Copy link
Contributor

@orta orta commented Mar 26, 2017

Looks perfect - thanks! Only a design request change, copy the design of the archives - http://artsy.github.io/blog/archives/

and instead of the year have something like "search results for Eigen"

Then this is a 👍

@ashfurrow
Copy link
Contributor Author

@ashfurrow ashfurrow commented Mar 26, 2017

Cool, updated this. Had to update the fork, added some documentation there about the modifications I've made. Here's a preview:

screen shot 2017-03-26 at 11 39 03 am

There are no results displayed while the search index is being downloaded (~3MB) so we should verify the UX is okay after deploying. Oh, and the search box on the search page is search-as-you-type, which is pretty cool.

@ashfurrow ashfurrow changed the title WIP: lunrjs Search lunrjs Search Mar 26, 2017
@orta
Copy link
Contributor

@orta orta commented Mar 27, 2017

Alright, looks good - nice work on the README for your fork 👍

@orta orta merged commit 9f65be6 into source Mar 27, 2017
2 checks passed
@orta orta deleted the search branch Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants