lunrjs Search #332
Merged
lunrjs Search #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks perfect - thanks! Only a design request change, copy the design of the archives - http://artsy.github.io/blog/archives/ and instead of the year have something like "search results for Eigen" Then this is a 👍 |
|
Cool, updated this. Had to update the fork, added some documentation there about the modifications I've made. Here's a preview:
There are no results displayed while the search index is being downloaded (~3MB) so we should verify the UX is okay after deploying. Oh, and the search box on the search page is search-as-you-type, which is pretty cool. |
|
Alright, looks good - nice work on the README for your fork 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #329
So we're using a fork of this library, because the library requires Jekyll 3 (as far as I can tell) and there are no semantic tags available to reference in our Gemfile. I added Jekyll 2-style posts, and there appeared to be some weirdness with emoji in Jekyll being index in lunr.js so I filtered them out of the index in the first way that Google suggested which looks terrible but works.
The design needs a little work for sure. Here's a before/after shot:
The downside compared to Google Site search is that we don't get a preview of the post, due to limitations in lunr.js. I think that's okay, but wanted to surface it for discussion.