This repository has been archived by the owner on Jan 4, 2023. It is now read-only.
@orta => Fixes many things #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently broken; gonna amend the last commit to not be broken tomorrow. |
|
Cool |
ashfurrow
changed the title
|
@orta this is ready for review 👾 |
| @@ -169,7 +171,7 @@ public class ListingsViewController: UIViewController { | |||
| developmentEnvironment = true | |||
| #else | |||
| if let ssid = getSSID() { | |||
| let developmentSSIDs = ["Ash's Wi-Fi Network", "Art.sy", "Artsy2"] as NSArray | |||
| let developmentSSIDs = ["Artsy"] as NSArray | |||
There was a problem hiding this comment.
I think Artsy 2 is still useful for 27
There was a problem hiding this comment.
Oh, I didn't realize that SSID was still in use.
|
|
|
I'm getting to be something of a gunslinger when it comes to interactive rebases. |
|
OK, looks good on a 2nd run through. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes unnecessary view controllers from storyboard
If you looked at the storyboard, there were two other VCs containing the starting VC.
Removes unused function
It's a function we were never using, and it was generating a warning due to it being
public, so I removed it.Fixes storyboard warnings
Lots of warnings like this:
Fixes intermittently failing tests
This was caused by SDWebImage caching images after the first tests were run. So the first tests passed because SDWebImage was actually trying to fetch images, but it wouldn't return them in time to set the images. It would then cache them to disk, so the next time you ran the tests, SDWebImage was able to use the on-disk cache.
So we use DI to avoid SDWebImage in tests.
Fixes WiFi name for testing at Artsy HQ
New wifi SSID means an update to our code.
Removes uses of println
Fixes #397.