Skip to content

Commit

Permalink
Remove the changelog check in danger
Browse files Browse the repository at this point in the history
  • Loading branch information
orta committed Jun 19, 2018
1 parent 919f6b6 commit a569ec8
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions Dangerfile
@@ -1,17 +1,11 @@
# This one runs on Travis CI runnning on a linux box
# There is another in Dangerfile.circle.rb

# Sometimes its a README fix, or something like that - which isn't relevant for
# including in a CHANGELOG for example
declared_trivial = github.pr_title.include?("#trivial") || github.pr_body.include?("#trivial")
declared_known_dev_tools = github.pr_body.include?("#known")

# Just to let people know
warn("PR is classed as Work in Progress") if github.pr_title.include? "[WIP]"

# Oi, CHANGELOGs please
fail("No CHANGELOG changes made") if git.lines_of_code > 50 && !git.modified_files.include?("CHANGELOG.yml") && !declared_trivial

# Stop skipping some manual testing
warn("Needs testing on a Phone if change is non-trivial") if git.lines_of_code > 50 && !github.pr_title.include?("📱")

Expand Down

0 comments on commit a569ec8

Please sign in to comment.