chore(deps): replace tipsi with official stripe lib #10451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5b5965c.
Co-authored-by: Carlos <araujobarret@gmail.com>
brainbicycle
commented
Jul 10, 2024
brainbicycle
commented
Jul 10, 2024
brainbicycle
commented
Jul 10, 2024
brainbicycle
commented
Jul 10, 2024
| // focus top field on mount | ||
| useEffect(() => { | ||
| paymentInfoRef.current?.focus() | ||
| }, []) |
There was a problem hiding this comment.
should be handled by autofocus prop
joeyAghion
previously approved these changes
Jul 10, 2024
|
Maybe we can also remove this extra call, I'm pretty sure it was there just because of tipsi |
gkartalis
previously approved these changes
Jul 11, 2024
Comment on lines
-63
to
-72
| ## react-native-credit-card-input | ||
|
|
||
| #### When can we remove this: | ||
|
|
||
| When we upgrade our deps to a version of react-native that includes removal of deprecated PropTypes. | ||
|
|
||
| #### Explanation/Context: | ||
|
|
||
| When updating to rn-0.69.10 we had to patch this due to deprecation of PropTypes. For this reason we also installed `deprecated-react-native-prop-types` to avoid errors and we patched the `react-native` package to use the deprecated PropTypes coming from the `deprecated-react-native-prop-types` package. | ||
|
|
Comment on lines
-166
to
-181
| ## react-native-credit-card-input | ||
|
|
||
| #### When can we remove this: | ||
|
|
||
| We can remove these hacks once we switch to Stripe's forthcoming official react-native library. | ||
|
|
||
| #### Explanation/Context: | ||
|
|
||
| These are fairly superficial styling hacks for | ||
|
|
||
| - focused/error border states | ||
| - shrinking the icon size to work nicely with our inputs | ||
| - aligning inner inputs nicely | ||
| - icon animation to work properly on android | ||
| - palette v3 colors | ||
|
|
There was a problem hiding this comment.
👋 awesome! we got rid of two hacks already 🔥
Comment on lines
-99
to
-121
| - Issue with installing `tipsi-stripe` | ||
|
|
||
| ``` | ||
| [!] CocoaPods could not find compatible versions for pod "tipsi-stripe": | ||
| ``` | ||
|
|
||
| You need to run | ||
|
|
||
| ``` | ||
| bundle exec pod update tipsi-stripe | ||
| ``` | ||
|
|
||
| - Error during `bundle exec pod update tipsi-stripe` | ||
|
|
||
| ``` | ||
| checking whether the C compiler works... no | ||
| xcrun: error: SDK "iphoneos" cannot be located | ||
| xcrun: error: SDK "iphoneos" cannot be located | ||
| xcrun: error: SDK "iphoneos" cannot be located | ||
| ``` | ||
|
|
||
| You need to go to Xcode -> Preferences -> Locations and select Command Line Tools from the dropdown | ||
|
|
araujobarret
previously approved these changes
Jul 11, 2024
brainbicycle
dismissed stale reviews from araujobarret, gkartalis, and joeyAghion
via
252d6dd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves PHIRE-1018
Description
Updates our payment dependencies from old tipsi forked + deprecated dependency to stripes official react native dependency.
Credit @araujobarret for much of the initial implementation: #9189
Before
before-low.mov
After
after-low.mov
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.