Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add danger changelog validation #4815

Merged
merged 7 commits into from
May 20, 2021

Conversation

MounirDhahri
Copy link
Member

@MounirDhahri MounirDhahri commented May 20, 2021

#run_new_changelog_check

The type of this PR is: feature

This PR resolves CX-1209

Description

  • add danger changelog validation

Changelog updates

Dev changes

  • Add PR changelog validation
  • Upgrade danger version

PR Checklist (tick all before merging)

  • I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
  • I have tested my changes on iOS and Android.
  • I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
  • I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added an app state migration, or my changes do not require one. (What are migrations?)
  • I have added a CHANGELOG.yml entry or my changes do not require one.

@ArtsyOpenSource
Copy link
Contributor

Fails
🚫 Danger failed to run `dangerfile.ts`.

Error Error

[BABEL] unknown: Preset /* your preset */ requires a filename to be set when babel is called directly,

babel.transform(code, { filename: 'file.ts', presets: [/* your preset */] });

See https://babeljs.io/docs/en/options#filename for more information.
Error: [BABEL] unknown: Preset /* your preset */ requires a filename to be set when babel is called directly,

babel.transform(code, { filename: 'file.ts', presets: [/* your preset */] });

See https://babeljs.io/docs/en/options#filename for more information.
    at validateIfOptionNeedsFilename (/home/circleci/project/node_modules/@babel/core/lib/config/full.js:286:11)
    at /home/circleci/project/node_modules/@babel/core/lib/config/full.js:298:52
    at Array.forEach (<anonymous>)
    at validatePreset (/home/circleci/project/node_modules/@babel/core/lib/config/full.js:298:25)
    at loadPresetDescriptor (/home/circleci/project/node_modules/@babel/core/lib/config/full.js:305:3)
    at loadPresetDescriptor.next (<anonymous>)
    at recursePresetDescriptors (/home/circleci/project/node_modules/@babel/core/lib/config/full.js:112:30)
    at recursePresetDescriptors.next (<anonymous>)
    at /home/circleci/project/node_modules/@babel/core/lib/config/full.js:186:21
    at Generator.next (<anonymous>)

Dangerfile

--------------^

Generated by 🚫 dangerJS

@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented May 20, 2021

This PR contains the following changes:

  • Dev changes (Add PR changelog validation,Upgrade danger version)

Generated by 🚫 dangerJS against 0732107

@MounirDhahri MounirDhahri changed the title feat: add danger changelog validation add danger changelog validation May 20, 2021
@MounirDhahri MounirDhahri changed the title add danger changelog validation feat: add danger changelog validation May 20, 2021
Copy link
Contributor

@brainbicycle brainbicycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup of the dangerfile!

@brainbicycle brainbicycle merged commit 232337f into master May 20, 2021
@brainbicycle brainbicycle deleted the add-danger-changelog-validation branch May 20, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants