feat: Validate PR description Changelogs on Eigen #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MounirDhahri
changed the title
MounirDhahri
commented
May 19, 2021
Comment on lines
+3
to
+7
| import { ParseResult } from "./helpers/changelog/changelog-types" | ||
| // @ts-ignore | ||
| import { parsePRDescription } from "./helpers/changelog/parsePRDescription.js" | ||
| // @ts-ignore | ||
| import { changelogTemplateSections } from "./helpers/changelog/generateChangelogSectionTemplate.js" |
There was a problem hiding this comment.
I think it might be better if I just create a new repo with these files to consume on both Eigen and here
| import yarn from "danger-plugin-yarn" | ||
| import { ParseResult } from "./helpers/changelog/changelog-types" | ||
| // @ts-ignore | ||
| import { parsePRDescription } from "./helpers/changelog/parsePRDescription.js" |
There was a problem hiding this comment.
why do we need ts-ignore here?
There was a problem hiding this comment.
typescript had issues importing javascript files. Maybe I can try to update the typescript config file to fix that as well
| } | ||
| `) | ||
| }) | ||
| }) |
brainbicycle
approved these changes
May 19, 2021
There was a problem hiding this comment.
This looks great to me 🤩 Going to assign @dblandin since he is more familiar with the repo and conventions here but nice work!!!
|
closing this since we can achieve the same behaviour on Eigen. This is the link for the PR artsy/eigen#4815 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the following RFC: Validate PR description Changelogs on Eigen
In order to not break our current workflows in Eigen, this rule will be temporarily running only on Eigen PRs containing
#run_new_changelog_checkin the PR body. Once we finish the remaining work on Eigen, we can safely enable it again for all PRs in Eigen.