This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
Dynamically sized image fetching. #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,13 +12,16 @@ import ImageView from '../../opaque_image_view'; | |||
| class Article extends React.Component { | |||
| render() { | |||
| const article = this.props.article | |||
| // TODO The outer wrapping view is currently only there because setting `marginRight: 20` on the Article from the | |||
There was a problem hiding this comment.
Yeah this is a weird thing - I find that setting the style of an entire component from the parent gives mixed results. I should read up on how flexbox reconciles self-styling and styling-by-parent.
|
🎉 |
alloy
pushed a commit
that referenced
this pull request
Jun 6, 2016
Dynamically sized image fetching.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #13.