Revert email analyzer #32
Conversation
Here's an example of a CHANGELOG.md entry: * [#32](https://github.com/artsy/estella/pull/32): Revert email analyzer - [@izakp](https://github.com/izakp).Generated by 🚫 Danger |
There was a problem hiding this comment.
I don't have much context for why the email analyzer was added in the first place (back during the v5 upgrade in #29). Is it possible some indices do use it, despite the higher-priority ngram analyzer?
|
Well, if it's not actually enabled or used in production, might as well remove it here! |
There was a problem hiding this comment.
I was wondering if might have been intended to support look up Users by email or something. But it sounds like it hasn't been used or missed, so I'm down to merge this.
|
@joeyAghion I think it was my mistake to add this. Most of our email fields are not analyzed. |
|
Seems like everyone's in agreement, so I'll go ahead and merge. The staging index might require a manual migration, if I understand correctly, right? |
|
@joeyAghion this will take an update of Estella and a version bump in Gravity. I think we should let the weekly reindex take care of this as indices are recreated |
|
Admin does still allow for search by email but it uses default and ngram analyzer and works fine I think, so there's no need for this analyzer currently. |
@cavvia right - this was an overoptimization on my part so let's release Estella and upgrade Gravity - the next staging reindex should clean up the index settings |
@anandaroop pointed out recently that our Elasticsearch index settings differ on staging and production and the email analyzer was never applied to production indices.
I believe that this change was introduced in error and has no effect due to its low position (after ngram) in the analysis pipeline.
cc @cavvia