Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release version 5.0.1 #34

Merged
merged 2 commits into from Mar 25, 2020
Merged

release version 5.0.1 #34

merged 2 commits into from Mar 25, 2020

Conversation

izakp
Copy link
Contributor

@izakp izakp commented Mar 23, 2020 •
edited

@izakp izakp requested a review from cavvia March 23, 2020 17:02
@izakp izakp self-assigned this Mar 23, 2020
@artsy artsy deleted a comment from artsy-peril bot Mar 23, 2020
@izakp
Copy link
Contributor Author

izakp commented Mar 23, 2020

https://stackoverflow.com/questions/35893584/nomethoderror-undefined-method-last-comment-after-upgrading-to-rake-11

@izakp
Copy link
Contributor Author

izakp commented Mar 23, 2020

Ach #33 failed due to an unrelated error - will rebase this tomorrow

@cavvia
Copy link
Contributor

cavvia commented Mar 24, 2020

@izakp Any idea what's happening with the build here?

@izakp
Copy link
Contributor Author

izakp commented Mar 24, 2020

@cavvia see that stackoverflow thread and c080188

@cavvia
Copy link
Contributor

cavvia commented Mar 25, 2020 •
edited

@izakp Thanks for chasing that error up! This will need a gem release as a follow up.

@cavvia cavvia merged commit 5129c3f into artsy:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cavvia cavvia Awaiting requested review from cavvia

Assignees

@izakp izakp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@izakp @cavvia