feat(EMI-1773): update copy for saves page tooltips and modals #13643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rquartararo
reviewed
Mar 27, 2024
src/Apps/CollectorProfile/Routes/Saves/Components/ArtworkListContent.tsx
Outdated
Show resolved
Hide resolved
rquartararo
previously approved these changes
Mar 27, 2024
oxaudo
requested changes
Mar 27, 2024
src/Apps/CollectorProfile/Routes/Saves/Components/ArtworkListContent.tsx
Show resolved
Hide resolved
Good callout, it was not mentioned in the ticket but we should update it there as well, thanks for flagging! |
fladson
deleted the
EMI-1773-update-copy-for-saves-page-tooltips-and-modals
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of this PR is: Feat
This PR solves EMI-1773
Description
Update the "Create a new list" description copy
Replace the lock icon for a hide icon
Update the list header to remove the list privacy (Shared or Private) and move the icon to the title itself
Add tooltips for both icons
Replace the lock icon in the SelectArtworkListItem modal
This will have merge conflicts with #13641, so we should merge that first.
@artsy/emerald-devs