feat(onyx-913): use new consignmentSubmission MP fields when rendering submission state section #13849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g submission state section
nickskalkin
commented
May 6, 2024
| STATUSES[displayText.toLowerCase()]?.description || "" | ||
| let stateLabelColor = "yellow150" | ||
| if (["APPROVED", "REJECTED", "CLOSED", "PUBLISHED"].includes(state)) | ||
| stateLabelColor = "orange150" |
There was a problem hiding this comment.
@joeyAghion you said that there are no submissions in "sold" state anymore - this we the only one with black100 color. It's ok that I do not support it anymore, right?
There was a problem hiding this comment.
Correct. That isn't a valid submission state, but came from the consigned_partner_submission that hasn't been in use recently.
dariakoko
approved these changes
May 6, 2024
joeyAghion
approved these changes
May 6, 2024
| STATUSES[displayText.toLowerCase()]?.description || "" | ||
| let stateLabelColor = "yellow150" | ||
| if (["APPROVED", "REJECTED", "CLOSED", "PUBLISHED"].includes(state)) | ||
| stateLabelColor = "orange150" |
There was a problem hiding this comment.
Correct. That isn't a valid submission state, but came from the consigned_partner_submission that hasn't been in use recently.
MounirDhahri
approved these changes
May 6, 2024
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of this PR is: Feat
This PR solves ONYX-913
Description
Parent Jira ticket with more details
Force/Eigen hardcode submission status labels and help messages. We've moved this logic to
myCollectionConnection...consignmentSubmissionMP field (artsy/metaphysics#5702) and in this PR we are replacing old "hardcoded" data with the new one taken from MP. Nothing should change visually, so I am not attaching screenshots.