Stitch in new reaction component for user payment form #3056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damassi
reviewed
Nov 6, 2018
| export const ReactionUserSettingsPayments = () => { | ||
| return ( | ||
| <ContextProvider user={sd.CURRENT_USER}> | ||
| <Renderer /> |
There was a problem hiding this comment.
Might be better to name this UserSettingsPayments (or unify the naming all around as there are a few permutations here)?
sweir27
force-pushed
the
alt-payment-form
branch
from
36cca36
to
2b21774
Compare
sweir27
changed the title
|
Going to merge this now that reaction is up-to-date! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from: artsy/reaction#1485
See that PR ☝️ for screengrab.
This just stitches in the payment form from reaction and deletes some unneeded code.
WIP just until I confirm for the last time with @briansw !