[Consignments] Move some tests to jest #5450
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5450 +/- ##
========================================
- Coverage 79.3% 79.3% -0.1%
========================================
Files 1250 1250
Lines 34066 34048 -18
Branches 2027 2027
========================================
- Hits 27046 27030 -16
+ Misses 6035 6033 -2
Partials 985 985 |
There was a problem hiding this comment.
I noticed a few assertions that read a little redundantly after translation by codemod. They are definitely minor, but I do think it's worth updating them, since tests are a thing that get copy-pasted pretty often.
Thank you for doing this!!! I really appreciate breaking the component tests into their own files, too.
| expect( | ||
| wrapper | ||
| .find(".consignments-submission-choose-artist__next-button[disabled]") | ||
| .props().disabled | ||
| ).toBe(true) |
There was a problem hiding this comment.
| expect( | |
| wrapper | |
| .find(".consignments-submission-choose-artist__next-button[disabled]") | |
| .props().disabled | |
| ).toBe(true) | |
| expect( | |
| wrapper | |
| .find(".consignments-submission-choose-artist__next-button[disabled]") | |
| .length | |
| ).toEqual(1) |
The codemod translated these assertions a bit funny, I think. Line 19 says "give me the button that is disabled", and line 20/21 say "make sure the button that is disabled is disabled".
I am not totally certain on the syntax of my suggestion, but I think it'd be worth updating these to assertions that don't unnecessarily inspect the props bag.
There was a problem hiding this comment.
This wasn't a codemod but an issue with Enzyme and perhaps how i swapped shallow for render: enzymejs/enzyme#336. It's pretty minor and the overall behavior is still being checked. (This applies to all the following tests.)
| expect( | ||
| wrapper | ||
| .find(".consignments-submission-choose-artist__next-button[disabled]") | ||
| .props().disabled | ||
| ).toBe(false) |
There was a problem hiding this comment.
| expect( | |
| wrapper | |
| .find(".consignments-submission-choose-artist__next-button[disabled]") | |
| .props().disabled | |
| ).toBe(false) | |
| expect( | |
| wrapper | |
| .find(".consignments-submission-choose-artist__next-button[disabled]") | |
| .length | |
| ).toEqual(1) |
| expect( | ||
| wrapper | ||
| .find( | ||
| ".consignments-submission-upload-photo__submit-button[disabled]" | ||
| ) | ||
| .prop("disabled") | ||
| ).toBe(false) |
There was a problem hiding this comment.
| expect( | |
| wrapper | |
| .find( | |
| ".consignments-submission-upload-photo__submit-button[disabled]" | |
| ) | |
| .prop("disabled") | |
| ).toBe(false) | |
| expect( | |
| wrapper | |
| .find( | |
| ".consignments-submission-upload-photo__submit-button[disabled]" | |
| ) | |
| .length | |
| ).toEqual(0) |
Strange that the codemod translated the assertion on line 24-28 one way, and the rest this way.
| expect( | ||
| wrapper | ||
| .find( | ||
| ".consignments-submission-upload-photo__submit-button[disabled]" | ||
| ) | ||
| .prop("disabled") | ||
| ).toBe(true) |
There was a problem hiding this comment.
| expect( | |
| wrapper | |
| .find( | |
| ".consignments-submission-upload-photo__submit-button[disabled]" | |
| ) | |
| .prop("disabled") | |
| ).toBe(true) | |
| expect( | |
| wrapper | |
| .find( | |
| ".consignments-submission-upload-photo__submit-button[disabled]" | |
| ) | |
| .length | |
| ).toEqual(1) |
This PR moves some of our tests over to jest and typescript:
I used a jest codemod to do most of it.
Got hung up on some mocha tests so will gradually migrate this to completion.