Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Decaffeination Export Error #6544

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Conversation

icirellik
Copy link
Contributor

While decaffeinating files the following export needed to be updated to
prevent a mismatch between module.exports and es6 style exports. I'm
still investigating to see if there is a way this type of mismatch can
be identified more easily while decaffeinating files.

While decaffeinating files the following export needed to be updated to
prevent a mismatch between `module.exports` and es6 style exports. I'm
still investigating to see if there is a way this type of mismatch can
be identified more easily while decaffeinating files.
Copy link
Member

@anandaroop anandaroop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix 🎉

Glad to see this could be done without a wholesale revert.

@anandaroop anandaroop added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Oct 26, 2020
@artsy-peril artsy-peril bot merged commit 871407a into master Oct 26, 2020
@artsy-peril artsy-peril bot deleted the fix-decaffeinated-updates branch October 26, 2020 20:11
@artsy-peril artsy-peril bot mentioned this pull request Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants