feat: Improve first and last onboarding step tracking GRO-61 #7057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonallured
force-pushed
the
jonallured/feat-improve-first-and-last-onboarding-step-tracking
branch
from
ca6ef97
to
ea4b887
Compare
damassi
reviewed
Feb 19, 2021
damassi
reviewed
Feb 19, 2021
damassi
reviewed
Feb 19, 2021
damassi
reviewed
Feb 19, 2021
damassi
reviewed
Feb 19, 2021
damassi
reviewed
Feb 19, 2021
damassi
reviewed
Feb 19, 2021
damassi
reviewed
Feb 19, 2021
damassi
approved these changes
Feb 19, 2021
There was a problem hiding this comment.
A couple minor requests, but otherwise stellar PR @jonallured 👍 Merge once those changes are made.
Also adds some tests.
jonallured
force-pushed
the
jonallured/feat-improve-first-and-last-onboarding-step-tracking
branch
from
ea4b887
to
e3f4dcb
Compare
jonallured
deleted the
jonallured/feat-improve-first-and-last-onboarding-step-tracking
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new onboarding tracking events for when a user picks interests and sets a budget. I followed some advice from this thread:
https://artsy.slack.com/archives/CP9P4KR35/p1613075517312100
And moved to wrapping the Wizard component in a
trackcall so that I could use hooks in the child components. This worked great! The only exception was the existing event that was triggered and has not been migrated to cohesion. After chatting with @abhitip about it, we decided to leave it alone so I just marked it asanyand moved on. We can come back to this if/when it makes sense.I was really happy to add a bunch of tests in this PR so that we have some confidence as we move forward working on the onboarding code - more to come on this!
This PR only addresses the first and last steps because those were easy to do, haha. Next up I'll work on the artist and category steps using the patterns outlined here.
https://artsyproduct.atlassian.net/browse/GRO-61
/cc @artsy/grow-devs