chore: GRO-213: Adding LazyLoadComponent to FooterBanner #7076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@The-Beez-Kneez - can you link to the JIRA ticket in the description? |
The-Beez-Kneez
changed the title
damassi
reviewed
Feb 23, 2021
| <ScrollIntoView | ||
| selector="#download-app-banner" | ||
| behavior="smooth" | ||
| > |
There was a problem hiding this comment.
I remembered this after pairing -- whenever we want something to jump to part of the page, we can wrap it in this component, and if we want to to animate we can use the behavior='smooth' prop
damassi
approved these changes
Feb 23, 2021
|
#mergeOnGreen |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: GRO-213
There were performance optimizations recommended by Damon for the footer.
The image in the footer should be lazy loaded and be a real
imgtag to increase accessibility.New layout:
