Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FX-3209 Updated articles carousel to v3 design #8329

Merged

Conversation

anastasiapyzhik
Copy link
Contributor

@anastasiapyzhik anastasiapyzhik commented Sep 1, 2021

FX-3209

This PR updates carousel on the Fair Overview tab from v2 component to v3

Before

bef

After

aft

@anastasiapyzhik anastasiapyzhik self-assigned this Sep 1, 2021
@anastasiapyzhik anastasiapyzhik marked this pull request as ready for review September 3, 2021 11:48
Copy link
Member

@dblandin dblandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

const articles = extractNodes(fair.articlesConnection)

return (
<Shelf alignItems="flex-start">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First time I've seen this new <Shelf> component. Cool!

@anastasiapyzhik anastasiapyzhik merged commit 899154f into master Sep 3, 2021
@anastasiapyzhik anastasiapyzhik deleted the anastasiapyzhik/FX-3209-update-carousels-to-v3 branch September 3, 2021 16:20
@artsy-peril artsy-peril bot mentioned this pull request Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants