slack notify dev when validate_production_schema fails #9780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damassi
reviewed
Mar 30, 2022
| parameters: | ||
| practice_web: | ||
| type: string | ||
| default: C2TQ4PT8R |
There was a problem hiding this comment.
Mind adding a comment here pointing to a link where this channel string was found? Will help future devs if this needs to be moved around.
damassi
previously approved these changes
Mar 30, 2022
ovasdi
force-pushed
the
ovasdi/circleci-slack
branch
from
d488c95
to
0db79e9
Compare
ovasdi
added
the
Squash On Green
damassi
added
Merge On Green
and removed
Squash On Green
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of this PR is: Enhancement
Description
Specify slack channels in the
validate_production_schemajob instead of post-steps to deliver notifications to both channels.In my testing, the post-step would not trigger a slack/notify if one of the required jobs fails and sends a slack notification.