Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to have a better branded name and [let's be honest] is cuter #77

Closed
alloy opened this issue May 21, 2019 · 9 comments · Fixed by #84
Closed

Rename to have a better branded name and [let's be honest] is cuter #77

alloy opened this issue May 21, 2019 · 9 comments · Fixed by #84

Comments

@alloy
Copy link
Collaborator

alloy commented May 21, 2019

In response to artsy/artsy.github.io#574 (comment) and to unblock artsy/artsy.github.io#566 (comment)

How about @artsy/fresnel?

The Fresnel equations […] describe the reflection […] of light […] when incident on an interface between different optical media.

https://en.wikipedia.org/wiki/Fresnel_equations

Or there may be other names to be found in the sphere of reflection (response) https://en.wikipedia.org/wiki/Reflection_(physics)

@ds300
Copy link

ds300 commented May 21, 2019

fresnel is great 👍

@alloy
Copy link
Collaborator Author

alloy commented May 21, 2019

TODO:

  • Rename in source files Rename library to Fresnel. #84
  • Rename git repo
  • Rename existing tags (prefixed them with rrm-)
  • npm deprecate @artsy/react-responsive-media@"<= 2.0.3" "WARNING: This project has been renamed to @artsy/fresnel."
  • Release a patch version to ensure the renaming worked properly.
  • Release v1

@alloy
Copy link
Collaborator Author

alloy commented May 21, 2019

@zephraph Anything additional we need to do re renovate?

@damassi
Copy link
Member

damassi commented May 21, 2019

Reminds me of a cute little 🐻

@alloy
Copy link
Collaborator Author

alloy commented May 22, 2019

@damassi I’m unsure what that’s in reference to… 😞 Care to fill me in?

@zephraph
Copy link
Contributor

@alloy nope, not that I'm aware of.

@damassi
Copy link
Member

damassi commented May 22, 2019

oh haha I just meant i like the name! it's cute

@alloy
Copy link
Collaborator Author

alloy commented May 24, 2019

Whoops

@alloy alloy reopened this May 24, 2019
@alloy
Copy link
Collaborator Author

alloy commented May 24, 2019

Ok, this is all done. Only thing that remains is to publish a v1, but I’ll leave that up to y’all.

@alloy alloy closed this as completed May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants