Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push git tags back upstream on deploy / promote #39

Closed
izakp opened this issue Sep 29, 2017 · 4 comments
Closed

Push git tags back upstream on deploy / promote #39

izakp opened this issue Sep 29, 2017 · 4 comments
Assignees

Comments

@izakp
Copy link
Contributor

izakp commented Sep 29, 2017

It would be nice to see the Hokusai tagging structure created for deploys / promotes {staging/production}--%yyyy-%mm-%dd--%hh-%MM-%ss pushed back to the upstream repo on deploy... though this would require CI to have a deploy key with write access.

Implement as a flag --push-git-tags {remote} that can be added to deploy / promote commands

@ashkan18
Copy link
Contributor

@orta mentioned https://aws.amazon.com/secrets-manager/ and i was wondering one approach could be have hokusai setup with different secret managers, maybe at first we can offer:

hokusai setup --secret-manager <env/aws-secret>

type of thing, where env is pretty much what we have now and we expect to get secrets from environment variables and for aws-secret we would get them from there.

@izakp
Copy link
Contributor Author

izakp commented May 3, 2018

@ashkan18 not sure how this relates to this issue which I opened to consider syncing git tags with ECR tags

@izakp
Copy link
Contributor Author

izakp commented May 3, 2018

@ashkan18 regarding supporting aws secrets manager, I think that's a bit out of scope for Hokusai as an external (to k8s) secret manager would need an integration with a given application to actually retrieve those secrets - I found this example of injecting secrets from the AWS secret manager service into a running container but it's more up to your application build as the entrypoint script is responsible for retrieving and injecting those secretes into the container environment https://medium.com/@mtreacher/using-aws-kms-for-application-secrets-in-kubernetes-149ffb6b4073

@izakp
Copy link
Contributor Author

izakp commented Jul 13, 2018

Closed by #71

@izakp izakp closed this as completed Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants