Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hokusai review_app list command #390

Merged
merged 1 commit into from
Dec 28, 2023
Merged

feat: hokusai review_app list command #390

merged 1 commit into from
Dec 28, 2023

Conversation

artsyjian
Copy link
Contributor

Solves #126

Introduce hokusai review_app list command which lists review apps of the project. It does so by listing Staging cluster namespaces that are labeled with:

  • app-name=<...project-name...>
  • app-phase=review

app-phase label is already being applied to review app namespaces. This PR introduces app-name label.

Example usage:

artsy:force jxu$ /Users/jxu/.pyenv/versions/hokusai/bin/hokusai review_app list
inbox2

Copy link
Contributor

@mc-jones mc-jones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature!

@mc-jones mc-jones merged commit fa7f840 into main Dec 28, 2023
4 checks passed
@mc-jones mc-jones deleted the artsyjian/reviewapp branch December 28, 2023 17:05
This was referenced Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants