Roughs in initial strategies #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be clear: the goal of this library is to provide a single API that supports generating on-demand resized image URLs from a variety of services. Everyone handles this differently and it's annoying to get right sometimes (Imgix's MD5 signature or the Lambda's Base64 encoding and payload format). |
mzikherman
approved these changes
Dec 7, 2022
| const query = stringify(params, { | ||
| arrayFormat: "brackets", | ||
| skipNulls: true, | ||
| sort: (a, b) => a.localeCompare(b), |
|
|
||
| const params = { | ||
| bucket: source.bucket, | ||
| key: src.replace(`${source.source}/`, ""), |
dzucconi
force-pushed
the
init
branch
2 times, most recently
from
660a15a
to
ef2ffb2
Compare
damassi
reviewed
Dec 7, 2022
dzucconi
force-pushed
the
init
branch
2 times, most recently
from
210d388
to
411d1f8
Compare
|
Preliminary local integration looks good. Going to merge and get CI set up; will integrate locally replacing the underlying Gemini URL creation then feature flag a service switcher and pass it along as a header to Metaphysics to sync the chosen service. |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will publish this locally using Yalc to drive out how to do integration in Force/Metaphysics along with setting a desired service.