Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing window.global #987

Closed
kanaabe opened this issue Mar 23, 2017 · 3 comments
Closed

Missing window.global #987

kanaabe opened this issue Mar 23, 2017 · 3 comments

Comments

@kanaabe
Copy link
Contributor

kanaabe commented Mar 23, 2017

I'd like to see a little more detail on this weird thing we have to do on React components. Is there something cleaner/clearer we can do to ensure that global is present on these components?
@kanaabe kanaabe mentioned this issue Mar 23, 2017
Merged
@eessex
Copy link
Contributor

eessex commented Mar 23, 2017

Not sure why this would be affecting the list view, but the window.global must be declared in all files that require Draft.

Currently that includes:
/client/apps/edit/components/section_text/index.coffee
/client/components/rich_text_caption/index.coffee
/client/components/rich_text/components/input_paragraph.coffee

As well as the corresponding tests to each.

@kanaabe
Copy link
Contributor Author

kanaabe commented Mar 23, 2017

Cool, thanks! I'm definitely confused by this still but if it happens on ArticleList maybe it's a React (since 15?) thing. Is there a Draft issue/doc that says you need the global?

@eessex
Copy link
Contributor

eessex commented Oct 18, 2017

Resolved in a newer version of draft

@eessex eessex closed this as completed Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eessex @kanaabe