Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@eessex => Make window.global available on ArticleList #988

Merged
merged 2 commits into from Mar 23, 2017

Conversation

kanaabe
Copy link
Contributor

@kanaabe kanaabe commented Mar 23, 2017

For now, adding the same window setter removes the undefined global issue, but there's def something about this that doesn't make sense. I made an issue here we can look at in our downtime.

@kanaabe
Copy link
Contributor Author

kanaabe commented Mar 23, 2017

@eessex changed this a bit and moved the global to main.coffee to ensure all client files have it. I still don't completely understand it so I'm keeping that issue open, but at least we won't have to think about requiring it on a per-file basis.

@eessex
Copy link
Contributor

eessex commented Mar 23, 2017

Ok seems like a sane solution for the moment. The only place I could see mention of requiring global was in this thread, where it has to do with creating/converting HTML Entities: facebookarchive/draft-js#55

@eessex eessex merged commit 8de79d9 into artsy:master Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants