Fixed bug reporting false positives with EmptyFunctionBlock

[cortinico]

This rule (EmptyFunctionBlock) had a bug in reporting functions with override and empty
blocks (with or without comments).

I'm fixing it and adding a couple of tests to make sure it works properly.

Fixes #1684

[rock3r]

Thanks for the fix Nico! I think we can take the opportunity to improve the docs a bit further, while we're at it :)

[rock3r]

Also the CI says you have conflicts :P

[cortinico]

Also the CI says you have conflicts :P

Yeah I should update my master from time to time 😆

[arturbosch]

Thanks for the fix!

[cortinico]

This should be good to go now imho

[schalkms]

Nice! Thank you very much!

[rock3r]

LGTM! Thanks Nicola :)

[codecov-io]

Codecov Report

Merging #1690 into master will decrease coverage by 3.83%.
The diff coverage is 80%.

@@             Coverage Diff              @@
##             master    #1690      +/-   ##
============================================
- Coverage     79.81%   75.98%   -3.84%     
- Complexity     1594     1853     +259     
============================================
  Files           229      328      +99     
  Lines          4335     5521    +1186     
  Branches        829     1007     +178     
============================================
+ Hits           3460     4195     +735     
- Misses          428      790     +362     
- Partials        447      536      +89

Impacted Files	Coverage Δ	Complexity Δ
...rturbosch/detekt/rules/empty/EmptyFunctionBlock.kt	91.66% <ø> (+16.66%)	8 <0> (+2)	⬆️
.../gitlab/arturbosch/detekt/rules/empty/EmptyRule.kt	86.66% <80%> (-4.25%)	10 <0> (+2)
...sch/detekt/rules/providers/PotentialBugProvider.kt	100% <0%> (ø)	3% <0%> (ø)	⬇️
...tekt/formatting/wrappers/SpacingAroundOperators.kt	100% <0%> (ø)	3% <0%> (?)
...arturbosch/detekt/formatting/FormattingProvider.kt	100% <0%> (ø)	3% <0%> (?)
...bosch/detekt/formatting/wrappers/ImportOrdering.kt	100% <0%> (ø)	3% <0%> (?)
...in/io/gitlab/arturbosch/detekt/api/SplitPattern.kt	75% <0%> (ø)	10% <0%> (?)
...turbosch/detekt/formatting/wrappers/PackageName.kt	100% <0%> (ø)	3% <0%> (?)
...io/gitlab/arturbosch/detekt/api/CompositeConfig.kt	60% <0%> (ø)	4% <0%> (?)
...n/io/gitlab/arturbosch/detekt/api/ConsoleReport.kt	0% <0%> (ø)	0% <0%> (?)
... and 93 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11abb88...0ac2a8d. Read the comment docs.