New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed build crash in gradle 8.0 #103
base: master
Are you sure you want to change the base?
Conversation
@kevalpatel2106 Thank you so much for this PR, it helps me get my own fork working. But one question, shouldn't line
|
@avalanchas Thanks for the feedback. This is my first time working with Gradle Plugin, so please bare me here. I am making the following changes to
I also found that Does it look correct? I tried running |
Very nice that we can work together on this, I am also pretty new to this. Yes that looks correct to me, since I was also just compiling this on a fork a second ago and saw that Hope that this can be merged soon |
Documentation for I couldn't find the migration doc, but this was a warning message was there before Gradle 8.0. |
@avalanchas Pushed new changes. @arturdm Can you take a look at this PR? As the Gradle 8 adoption increases in the Android project, I think we will start getting more and more issues about plugin failing the build. I suggest we treat it as an urgent fix. As I said above, very new to gradle plugins. So, happy to hear any suggestions. |
@kevalpatel2106 Are you planning to take over maintenance and to publish your fork on Maven Central? |
e87d18a
to
5ecca25
Compare
@kevalpatel2106 I applied your fork, but still I have:
|
Hello folks 👋 Thanks. |
The Jacoco Android plugin is not yet compatible with Gradle 8.0, so I disabled it. We'll have to put it back after it's working again. c.f. arturdm/jacoco-android-gradle-plugin#103
closes: #102
Updated the
jacocoTestReport
properties fromenabled
torequired
as mentioned by Gradle documentation for plugin.I tested the project builds on both Gradle 7.0.2 (current version in master) and Gradle 8.0.