adding GB and FI sub-territories support #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hajk1
pushed a commit
to hajk1/iban4j
that referenced
this pull request
Oct 2, 2023
Co-authored-by: Remy Duval <remy.duval@nickel.eu>
hajk1
added a commit
that referenced
this pull request
Oct 2, 2023
* enable Java 8 * checks for national check digit be present in BBAN * enable skipTests * dependency update * Bump junit from 4.11 to 4.13.1 Bumps [junit](https://github.com/junit-team/junit4) from 4.11 to 4.13.1. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.11.md) - [Commits](junit-team/junit4@r4.11...r4.13.1) Signed-off-by: dependabot[bot] <support@github.com> * #67: fix VG struncture * java 6 replaced with java 7 * Belarus BBAN bug fixed * update oss plugin * release 3.2.2-RELEASE * Add French subterritories support * release 3.2.3-RELEASE * add 3.2.3-RELEASE to the README.md * #67: add VA iban structure * upgrade jacoco maven plugin inorder to support Java versions higher than 8 * update Maven config - remove deprecated parent pom - bump java version to 1.8 - add maven wrapper - bump versions - change broken project URL to GitHub project URL - add maven wrapper * adding Iraq IBAN support * new release updated * added Egypt IBAN structure * Adding Gabon BbanStructure Added correct BbanStructure for Gabon and included Test case * Release 3.2.5 * Fix typo in Guernsey * adding GB and FI sub-territories support (#100) Co-authored-by: Remy Duval <remy.duval@nickel.eu> * Refactor tests (#108) * update junit version to 5 * update junit version to 5 * test cases refactored * test cases refactored * test cases refactored * test cases refactored to new class * test cases refactored * test cases refactored * test cases refactored * Parametrized test cases refactored * Hamcrest test cases refactored * fixing test case * fixing test case * fixing test case * fixing test case * fixing test case * fixing test case * fixing test case * fixing test case * fixing test case * fixing test case * fixing test case * fixing test case * fixing test case * fixing test case * fixing test case * fixing test case * Create CODE_OF_CONDUCT.md * GitHub action (#109) * testing github action * testing github action java * testing github action java * testing github action * testing github action * testing github action * GitHub action (#110) * testing github action * testing github action java * testing github action java * testing github action * testing github action * testing github action * testing github action * GitHub action (#111) * testing github action * testing github action java * testing github action java * testing github action * testing github action * testing github action * testing github action * update java adopt jdk badge * Issue 33 (#112) * update java adopt jdk badge * adding non default padded character * adding branch code to use padding left * change the README.md * release 3.2.6-RELEASE * fixed formatting * fixed formatting * Issue 101 (#113) * adding two new methods * adding test for the isValid false results * adding missing tests * adding valid tests for isValid * making static utility methods public (#118) * Add GitHub action for verifying tests (#94) * add GHA for maven verify * add GHA for maven verify * add test report step * experimenting with some other reporting actions * tweaking GHA * tweaking GHA * tweaking GHA * tweaking GHA * rm broken/buggy test report actions * try fixing jacoco report * rm jacoco report upload * rm jacoco report upload * rm jacoco report upload * Delete .github/workflows/build-github-actions.yml deleted because of new ci yml * exception changed to iban4jException (#119) * bank code validation changed to accept alphanumeric values * 3.2.7 released * readme updated to show 3.2.7 release * changing the urls to make renovatebot happy (#121) * Adding Cap Verde structure (#102) * Adding Cap Verde structure * Adding tests for CV --------- Co-authored-by: RHoog <romain.hoog@kshuttle.io> * Allow setting a custom Random (#93) * fix spelling mistake, ibanContruction -> ibanConstruction * add overload to allow passing a custom Random - add toString() to BbanStructureEntry.java - tests to check if randomness is deterministic - add additional tests for validity of BbanStructureEntry.java - TODO figure out if 'c' can generate a-z * remove TODO - a-z is not required * fix code suggestions/warnings * update tests to JUnit5 * remove duplicated `ibanConstructionRandom()` test * update assertions * fix test name after merge * update expected random values * re-add accidentally removed test --------- Co-authored-by: aSemy <aSemy@users.noreply.github.com> * checks for national check digit be present in BBAN * enable skipTests * Adding Gabon BbanStructure Added correct BbanStructure for Gabon and included Test case * GitHub action (#109) * testing github action * testing github action java * testing github action java * testing github action * testing github action * testing github action * Delete .github/workflows/build-github-actions.yml deleted because of new ci yml * Adding Gabon BbanStructure Added correct BbanStructure for Gabon and included Test case * GitHub action (#109) * testing github action * testing github action java * testing github action java * testing github action * testing github action * testing github action * Delete .github/workflows/build-github-actions.yml deleted because of new ci yml * making java 8 release compatible * Adding Gabon BbanStructure Added correct BbanStructure for Gabon and included Test case * GitHub action (#109) * testing github action * testing github action java * testing github action java * testing github action * testing github action * testing github action * Delete .github/workflows/build-github-actions.yml deleted because of new ci yml --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: hajk1 <BlackHeart59> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Constantin Costescu <constantineugen.costescu@gmail.com> Co-authored-by: Kevin Aldebert <kevin@yomoni.fr> Co-authored-by: Adam <897017+aSemy@users.noreply.github.com> Co-authored-by: Kayvan Tehrani <tehrani.k@dpi.ir> Co-authored-by: Bogac Aslanyurek <b.aslanyurek@gmail.com> Co-authored-by: dvg2207x <lx14578@innovaccion.mx> Co-authored-by: Becky Fulton <102167563+becky-sequence@users.noreply.github.com> Co-authored-by: Rémy Duval <58892560+remy-duval@users.noreply.github.com> Co-authored-by: Remy Duval <remy.duval@nickel.eu> Co-authored-by: hoorom <58820415+hoorom@users.noreply.github.com> Co-authored-by: RHoog <romain.hoog@kshuttle.io> Co-authored-by: aSemy <aSemy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
I'd like to propose a few changes to better match what I understood from https://www.iban.com/structure: