Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting a custom Random #93

Merged
merged 11 commits into from
Oct 2, 2023
Merged

Allow setting a custom Random #93

merged 11 commits into from
Oct 2, 2023

Conversation

aSemy
Copy link
Contributor

@aSemy aSemy commented Aug 19, 2022 •
edited
Loading

Allow passing in a custom random, so users can make the generation deterministic.

resolves #91

Summary

  • fix spelling mistake in test, ibanContruction -> ibanConstruction
  • add toString() to BbanStructureEntry.java (this helps the test error messages)
  • tests to check if randomness is deterministic
  • add additional tests for validity of BbanStructureEntry.java

TODO

  • I was confused by the EntryCharacterType - need to remove the TODO comment and possibly update the Javadoc

@Bas-Boven
Copy link

We are eagerly expecting this improvement. Would love to see it merged!

@FrankHossfeld FrankHossfeld mentioned this pull request Oct 8, 2022
Closed
@aSemy aSemy mentioned this pull request Oct 20, 2022
Merged
@hajk1 hajk1 added this to the 3.2.8-RELEASE milestone Aug 8, 2023
aSemy and others added 7 commits August 8, 2023 09:51
@aSemy
fix spelling mistake, ibanContruction -> ibanConstruction
a1e3cfe
@aSemy
add overload to allow passing a custom Random
874bc71 
- add toString() to BbanStructureEntry.java
- tests to check if randomness is deterministic
- add additional tests for validity of BbanStructureEntry.java
- TODO figure out if 'c' can generate a-z
@aSemy
remove TODO - a-z is not required
f8568db
@aSemy
fix code suggestions/warnings
df77bcb
@aSemy
update tests to JUnit5
e4a1965
@aSemy
remove duplicated ibanConstructionRandom() test
c378b87
@aSemy
update assertions
ff4f82a
@aSemy aSemy requested a review from hajk1 August 8, 2023 12:02
@hajk1 hajk1 merged commit 7fbbe21 into arturmkrtchyan:master Oct 2, 2023
1 check passed
@aSemy aSemy deleted the feat/custom-random branch October 2, 2023 07:41
hajk1 pushed a commit to hajk1/iban4j that referenced this pull request Oct 2, 2023
@aSemy @hajk1
Allow setting a custom Random (arturmkrtchyan#93)
a90c8fb 
* fix spelling mistake, ibanContruction -> ibanConstruction

* add overload to allow passing a custom Random

- add toString() to BbanStructureEntry.java
- tests to check if randomness is deterministic
- add additional tests for validity of BbanStructureEntry.java
- TODO figure out if 'c' can generate a-z

* remove TODO - a-z is not required

* fix code suggestions/warnings

* update tests to JUnit5

* remove duplicated `ibanConstructionRandom()` test

* update assertions

* fix test name after merge

* update expected random values

* re-add accidentally removed test

---------

Co-authored-by: aSemy <aSemy@users.noreply.github.com>
hajk1 added a commit that referenced this pull request Oct 2, 2023
@hajk1 @dependabot
@ccostin93 @kaldebert @aSemy @bogacaslan @dvg2207x @becky-sequence @remy-duval @hoorom
Resolve conflict (#123)
e2d25eb 
* enable Java 8

* checks for national check digit be present in BBAN

* enable skipTests

* dependency update

* Bump junit from 4.11 to 4.13.1

Bumps [junit](https://github.com/junit-team/junit4) from 4.11 to 4.13.1.
- [Release notes](https://github.com/junit-team/junit4/releases)
- [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.11.md)
- [Commits](junit-team/junit4@r4.11...r4.13.1)

Signed-off-by: dependabot[bot] <support@github.com>

* #67: fix VG struncture

* java 6 replaced with java 7

* Belarus BBAN bug fixed

* update oss plugin

* release 3.2.2-RELEASE

* Add French subterritories support

* release 3.2.3-RELEASE

* add 3.2.3-RELEASE to the README.md

* #67: add VA iban structure

* upgrade jacoco maven plugin inorder to support Java versions higher than 8

* update Maven config

- remove deprecated parent pom
- bump java version to 1.8
- add maven wrapper
- bump versions
- change broken project URL to GitHub project URL
- add maven wrapper

* adding Iraq IBAN support

* new release updated

* added Egypt IBAN structure

* Adding Gabon BbanStructure

Added correct BbanStructure for Gabon and included Test case

* Release 3.2.5

* Fix typo in Guernsey

* adding GB and FI sub-territories support (#100)

Co-authored-by: Remy Duval <remy.duval@nickel.eu>

* Refactor tests (#108)

* update junit version to 5

* update junit version to 5

* test cases refactored

* test cases refactored

* test cases refactored

* test cases refactored to new class

* test cases refactored

* test cases refactored

* test cases refactored

* Parametrized test cases refactored

* Hamcrest test cases refactored

* fixing test case

* fixing test case

* fixing test case

* fixing test case

* fixing test case

* fixing test case

* fixing test case

* fixing test case

* fixing test case

* fixing test case

* fixing test case

* fixing test case

* fixing test case

* fixing test case

* fixing test case

* fixing test case

* Create CODE_OF_CONDUCT.md

* GitHub action (#109)

* testing github action

* testing github action java

* testing github action java

* testing github action

* testing github action

* testing github action

* GitHub action (#110)

* testing github action

* testing github action java

* testing github action java

* testing github action

* testing github action

* testing github action

* testing github action

* GitHub action (#111)

* testing github action

* testing github action java

* testing github action java

* testing github action

* testing github action

* testing github action

* testing github action

* update java adopt jdk badge

* Issue 33 (#112)

* update java adopt jdk badge

* adding non default padded character

* adding branch code to use padding left

* change the README.md

* release 3.2.6-RELEASE

* fixed formatting

* fixed formatting

* Issue 101 (#113)

* adding two new methods

* adding test for the isValid false results

* adding missing tests

* adding valid tests for isValid

* making static utility methods public (#118)

* Add GitHub action for verifying tests (#94)

* add GHA for maven verify

* add GHA for maven verify

* add test report step

* experimenting with some other reporting actions

* tweaking GHA

* tweaking GHA

* tweaking GHA

* tweaking GHA

* rm broken/buggy test report actions

* try fixing jacoco report

* rm jacoco report upload

* rm jacoco report upload

* rm jacoco report upload

* Delete .github/workflows/build-github-actions.yml

deleted because of new ci yml

* exception changed to iban4jException (#119)

* bank code validation changed to accept alphanumeric values

* 3.2.7 released

* readme
updated to show 3.2.7 release

* changing the urls to make renovatebot happy (#121)

* Adding Cap Verde structure (#102)

* Adding Cap Verde structure

* Adding tests for CV

---------

Co-authored-by: RHoog <romain.hoog@kshuttle.io>

* Allow setting a custom Random (#93)

* fix spelling mistake, ibanContruction -> ibanConstruction

* add overload to allow passing a custom Random

- add toString() to BbanStructureEntry.java
- tests to check if randomness is deterministic
- add additional tests for validity of BbanStructureEntry.java
- TODO figure out if 'c' can generate a-z

* remove TODO - a-z is not required

* fix code suggestions/warnings

* update tests to JUnit5

* remove duplicated `ibanConstructionRandom()` test

* update assertions

* fix test name after merge

* update expected random values

* re-add accidentally removed test

---------

Co-authored-by: aSemy <aSemy@users.noreply.github.com>

* checks for national check digit be present in BBAN

* enable skipTests

* Adding Gabon BbanStructure

Added correct BbanStructure for Gabon and included Test case

* GitHub action (#109)

* testing github action

* testing github action java

* testing github action java

* testing github action

* testing github action

* testing github action

* Delete .github/workflows/build-github-actions.yml

deleted because of new ci yml

* Adding Gabon BbanStructure

Added correct BbanStructure for Gabon and included Test case

* GitHub action (#109)

* testing github action

* testing github action java

* testing github action java

* testing github action

* testing github action

* testing github action

* Delete .github/workflows/build-github-actions.yml

deleted because of new ci yml

* making java 8 release compatible

* Adding Gabon BbanStructure

Added correct BbanStructure for Gabon and included Test case

* GitHub action (#109)

* testing github action

* testing github action java

* testing github action java

* testing github action

* testing github action

* testing github action

* Delete .github/workflows/build-github-actions.yml

deleted because of new ci yml

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: hajk1 <BlackHeart59>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Constantin Costescu <constantineugen.costescu@gmail.com>
Co-authored-by: Kevin Aldebert <kevin@yomoni.fr>
Co-authored-by: Adam <897017+aSemy@users.noreply.github.com>
Co-authored-by: Kayvan Tehrani <tehrani.k@dpi.ir>
Co-authored-by: Bogac Aslanyurek <b.aslanyurek@gmail.com>
Co-authored-by: dvg2207x <lx14578@innovaccion.mx>
Co-authored-by: Becky Fulton <102167563+becky-sequence@users.noreply.github.com>
Co-authored-by: Rémy Duval <58892560+remy-duval@users.noreply.github.com>
Co-authored-by: Remy Duval <remy.duval@nickel.eu>
Co-authored-by: hoorom <58820415+hoorom@users.noreply.github.com>
Co-authored-by: RHoog <romain.hoog@kshuttle.io>
Co-authored-by: aSemy <aSemy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hajk1 hajk1 hajk1 approved these changes

Assignees

@aSemy aSemy

Labels
None yet
Projects
None yet
Milestone
3.2.8-RELEASE
Development

Successfully merging this pull request may close these issues.

Allow setting a seed for Random
3 participants
@aSemy @Bas-Boven @hajk1