Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer (and other miniobject) COW writability not mapped very well #24

Open
sdroege opened this issue Feb 3, 2017 · 0 comments
Open

Comments

@sdroege
Copy link

sdroege commented Feb 3, 2017

You might want to take a look at https://github.com/sdroege/rsplugin/blob/master/gst-plugin/src/buffer.c and https://github.com/sdroege/rsplugin/blob/master/gst-plugin/src/miniobject.rs . I'm implementing the miniobject COW via something Arc-style.

With that you will only ever be able to get a &mut Buffer if the buffer is actually writable, and have to explicitly handle that instead of waiting for runtime errors or worse if make_writable() is not called manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant