Fix bug where ephemeral logs were not getting cleared #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure 'ephemeral' and 'before' are not references to the same object - Use 'ephemeral' variable and not 'before' in log-clearing query - Use 'setTime' and not 'setDate' when setting via timestamp - Fix log purge test same as above - Fix log purge test by removing extraneous whitespace in 'ephemeralLogStatuses' - Correct 'microseconds' to 'milliseconds' in docs/comments - Add package name to package.js - Add underscore to support Meteor 1.2 (since meteor-platform goes away)
artwells
added a commit
that referenced
this pull request
Oct 4, 2015
Fix bug where ephemeral logs were not getting cleared
|
Thanks! Looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thanks for the package. Great work. So much easier to drop in a database queue if possible rather than setup a whole other service just to queue jobs.
I had a problem where the ephemeral logs were not getting cleared in my database. Over time, it generated over 1MM records in the log. I noticed a number of issues with both the code designed to purge ephemeral logs and in the test for the same. I think, due to some interactions and by sheer coincidence, the test passed in spite of these issues. In creating this PR, I got the tests broken, then got them passing again with these changes.
Details are in the commit message. What do you think? Possible to release these soon?