Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For better readability and ease of feature adding (like I'm planning to add a "margin" field to separate the modules at will, and not the default 0.1 for rounded modules), I think it will be better to just have 1 single
printSvg
procedure.Issues:
The proc doesn't know if the user passed a 0 explicitly or not to
moRad
oralRad
, but this should not be an issue at all unless the user wants to have an SVG with individual modules and alignment patterns (I mean them being drawed as<rec>
instead of a<path>
).Solution 1: Use
Option
, problem: I don't like how the user will need to usesome()
to pass values.Solution 2 (imo the best): If the user really wants to do what I said before, we could just add a
useRect
bool field, if true the proc will not care if the specified radius is 0 or whatever.Comment which solution you like, or add a new one.
Edit: note how this also fixes an issue where you can't set
moRad
without settingalRad
.