-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.0.0 #28
Merged
Merged
Release 2.0.0 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Yardanico
I think it's very unintuitive to have the the radius parameters be an absolute size instead of a percentage, like 60%, 40%, etc. At least for SVGs.
It already gets the pushed commit, and fixes an issue found in #23.
Reason: idk why, but it broke, the workflow always runs with ref to main, which makes no sense. So I will just test if this fixes it
Also removing normal test blocks when benchmark flag is specified.
Feature: more intuitive radius (SVG)
aruZeta
force-pushed
the
release/2.0.0
branch
2 times, most recently
from
September 15, 2022 13:32
602df87
to
70ad676
Compare
aruZeta
force-pushed
the
release/2.0.0
branch
from
September 15, 2022 13:37
70ad676
to
daa8336
Compare
aruZeta
added
the
roadmap
This ISSUE or PR is part of the roadmap of the project.
label
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listing of breaking changes:
printSvg
proc overloads Feature: Only 1 print proc (SVG) #24newQR
andnewQRCode
overloads Refactor: removenewQR
overloads #25printSvg
,moSep
Feature: custom module separation #26<rect>
in<g>
Feature: Grouping rects in a<g>
#27moSep
into aPercentage
Feature: makemoSep
aPercentage
#29Fixes to be made using the new API:
All API changes have been made towards
printSvg
.Other changes: