Correct GdkPixbuf byte length and simplify decoder #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 25, 2014 22:47
The one extra loading buffer was completely unnecessary for incremental loading. Data can be decoded directly into the pixbuf. By removing the buffer, both memory and computational complexity improves significantly. The pixel data is now initialised to 0x00, so that the user doesn't receive random garbage while the picture is still loading. I also inlined the function I added in my recent commit.
At least not necessarily, as per documentation.
dmazary
added a commit
that referenced
this pull request
Oct 23, 2014
Correct GdkPixbuf byte length and simplify decoder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge decoder updates from pjanouch