Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct GdkPixbuf byte length and simplify decoder #2

Merged
merged 2 commits into from Oct 23, 2014
Merged

Correct GdkPixbuf byte length and simplify decoder #2

merged 2 commits into from Oct 23, 2014

Commits on Mar 25, 2014

  1. Simplify and optimise 

    The one extra loading buffer was completely unnecessary for incremental loading.
Data can be decoded directly into the pixbuf.  By removing the buffer, both
memory and computational complexity improves significantly.

The pixel data is now initialised to 0x00, so that the user doesn't receive
random garbage while the picture is still loading.

I also inlined the function I added in my recent commit.
    Přemysl Janouch committed Mar 25, 2014
    Configuration menu
    Copy the full SHA
    96e9afa View commit details
    Browse the repository at this point in the history

  2. GdkPixbuf's byte length != height * stride 

    At least not necessarily, as per documentation.
    Přemysl Janouch committed Mar 25, 2014
    Configuration menu
    Copy the full SHA
    978af60 View commit details
    Browse the repository at this point in the history