Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added options to change the size of the user's image #61

Merged
merged 3 commits into from Jun 24, 2013

Conversation

Projects
None yet
2 participants
Contributor

guilhermesimoes commented Jun 19, 2013

Closes #11

I actually spent more time trying to get the tests to work but hey, at least I learnt something. 😄

Facebook's normal gets a 100x100 image and small gets a 50x50 image.
Meanwhile Twitter's normal gets a 48x48 image and bigger gets a 70x70 image. Oh well.

Change order of options.
Also wrap possible values with backticks.
(Yep, my bad)
Owner

arunagw commented Jun 19, 2013

I really appreciate your effort but it seems it's not going to work as we have already have a bug.

In info you do not have any options. So basically secure_image_url feature was also not working.

Will you able to get time to fix this? And see what's happening in that?

thanks in advance.

Contributor

guilhermesimoes commented Jun 19, 2013

In info, you do have options. In fact, the secure_image_url feature depended on options existing:

:image => options[:secure_image_url] ? raw_info['profile_image_url_https'] : raw_info['profile_image_url']

Now, I'm just passing the whole options hash.

The tests passed locally and I even tried my branch on a small project, bummer. I'll take a look 😒

Contributor

guilhermesimoes commented Jun 19, 2013

A-ha! I created a Travis account just to try forcing this thing to run again and what do you know, it passed. Travis messing with me? :shipit:

Owner

arunagw commented Jun 20, 2013

I tried on omniauth.org project.

Can you post that project on github so I can clone and see result?

Thanks for working on this 💚

Contributor

guilhermesimoes commented Jun 20, 2013

Sure. https://github.com/GuilhermeSimoes/omniauth-popup

You'll have to set your own key and secret though.

guilhermesimoes added some commits Jun 19, 2013

Add option image_size.
Also add some specs.
Finally, update README to reflect code changes.

arunagw added a commit that referenced this pull request Jun 24, 2013

Merge pull request #61 from GuilhermeSimoes/image-size
Added options to change the size of the user's image

@arunagw arunagw merged commit b044261 into arunagw:master Jun 24, 2013

1 check passed

default The Travis CI build passed
Details
Owner

arunagw commented Jun 24, 2013

thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment