Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added options to change the size of the user's image #61

Merged
merged 3 commits into from
Jun 24, 2013
Merged

Added options to change the size of the user's image #61

merged 3 commits into from
Jun 24, 2013

Conversation

guilhermesimoes
Copy link
Contributor

Closes #11

I actually spent more time trying to get the tests to work but hey, at least I learnt something. 😄

Facebook's normal gets a 100x100 image and small gets a 50x50 image.
Meanwhile Twitter's normal gets a 48x48 image and bigger gets a 70x70 image. Oh well.

Also wrap possible values with backticks.
(Yep, my bad)
@arunagw
Copy link
Owner

arunagw commented Jun 19, 2013

I really appreciate your effort but it seems it's not going to work as we have already have a bug.

In info you do not have any options. So basically secure_image_url feature was also not working.

Will you able to get time to fix this? And see what's happening in that?

thanks in advance.

@guilhermesimoes
Copy link
Contributor Author

In info, you do have options. In fact, the secure_image_url feature depended on options existing:

:image => options[:secure_image_url] ? raw_info['profile_image_url_https'] : raw_info['profile_image_url']

Now, I'm just passing the whole options hash.

The tests passed locally and I even tried my branch on a small project, bummer. I'll take a look 😒

@guilhermesimoes
Copy link
Contributor Author

A-ha! I created a Travis account just to try forcing this thing to run again and what do you know, it passed. Travis messing with me? :shipit:

@arunagw
Copy link
Owner

arunagw commented Jun 20, 2013

I tried on omniauth.org project.

Can you post that project on github so I can clone and see result?

Thanks for working on this 💚

@guilhermesimoes
Copy link
Contributor Author

Sure. https://github.com/GuilhermeSimoes/omniauth-popup

You'll have to set your own key and secret though.

Also add some specs.
Finally, update README to reflect code changes.
arunagw added a commit that referenced this pull request Jun 24, 2013
Added options to change the size of the user's image
@arunagw arunagw merged commit b044261 into arunagw:master Jun 24, 2013
@arunagw
Copy link
Owner

arunagw commented Jun 24, 2013

thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need ability to specify image size
2 participants