Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension stopped working #51

Open
883km opened this issue Nov 14, 2023 · 27 comments
Open

Extension stopped working #51

883km opened this issue Nov 14, 2023 · 27 comments
Assignees
Labels
bug Something isn't working

Comments

@883km
Copy link

883km commented Nov 14, 2023

The Chrome extension stopped working since about 22 hours ago. This happened before and the problem would be gone if I tried to submit on LeetCode a few more times. But this time the issue persists. I was wondering if there’s any bug or is there any solution for the issue on my end?

@883km 883km added the bug Something isn't working label Nov 14, 2023
@cathalpaz
Copy link

Not working for me either :(

@lizihanov17
Copy link

It also doesn’t work on my chrome

@hyunjinjeong
Copy link

Try changing the LeetCode UI to the old version until the issue gets fixed

@lizihanov17
Copy link

Try changing the LeetCode UI to the old version until the issue gets fixed

Do you mean to stop using the Dynamic layout and revert to split view mode? I tried this but still failed

@aystream
Copy link
Contributor

@hyunjinjeong I can fix this quickly, will you accept my pull request?

@hyunjinjeong
Copy link

@lizihanov17

When you click your profile icon, there is a Revert to old version button. In my case, the extension worked again after reverting the UI.

@aystream

I'm sorry but I'm not a maintainer 😢

aystream referenced this issue in aystream/LeetHub-2.0 Nov 15, 2023
Enhanced the function isLeetCodeV2 to more accurately determine if the current page is a version of LeetCode. The function now checks for the presence of specific root elements and body classes that indicate whether the page is using Chakra UI light or dark themes, as well as the presence of the "__next" root element. This ensures a more reliable and precise detection of LeetCode's version and UI themes, improving the overall functionality of the script.

Issue: QasimWani#51
@aystream
Copy link
Contributor

Hi @arunbhardwaj,

I've submitted a pull request addressing the issue with the LeetCode V2 detection function. I've made enhancements to the isLeetCodeV2 function, ensuring it more accurately identifies the LeetCode page version and UI theme.

These changes have been thoroughly tested on my local machine with different scenarios. The extension now performs more reliably with the updated logic.

I look forward to your feedback and am happy to make any further adjustments as needed.

Thank you for your time and consideration.

@py3-coder
Copy link

Is it working now for other ? Still not working for me?

@aystream
Copy link
Contributor

Is it working now for other ? Still not working for me?

It works in the pull request branch, no one has merged it so far

@codesejin
Copy link

Still not working 😢

@chaoting-sun
Copy link

Not working now.

csbt referenced this issue in csbt/LeetHub-2.0 Nov 17, 2023
Update LeetCodeV2 detection mechanism; Rehandle submit by keyboard
shortcuts; Use MutationObserver to determine when the submit button
elements are loaded

BREAKING CHANGE: 🧨 Detecting LeetCodeV2 by the presence of submit button

✅ Closes: QasimWani#51
@toufiq-dev
Copy link

Still not working

@MITTALBHAVYA
Copy link

not working brother

@snowphone
Copy link

I hope this PR is merged and deployed soon.

@JCharante
Copy link

JCharante commented Nov 21, 2023

New version is published to chrome store asking for new perms but there's no new commits to the repo? Uninstalling until things become clear

@JCharante
Copy link

update: while chrome did prompt me to allow new permissions on leethub (and I've had it installed for about 3 weeks), the chrome store page is showing it hasn't been updated since July 25, 2023. I'm not sure what prompted chrome to show that message, but some communication from the author would be appreciated.

@raphaelheinz
Copy link

If @arunbhardwaj no longer has time for this project, I would suggest creating a new repository to continue the work. What do you guys think?

But let's wait a few more days, maybe he's just temporarily busy :)

@raphaelheinz
Copy link

I have forked this repository and will continue to work on the new project. It looks like the original maintainer doesn't have time at the moment. Please help to improve this awesome plugin. Your pull requests are welcome!

Please check: https://github.com/raphaelheinz/LeetHub-3.0/

@snowphone
Copy link

@raphaelheinz Did you upload leethub 3.0 to Chrome web store, or not yet?

@JCharante
Copy link

@raphaelheinz Did you upload leethub 3.0 to Chrome web store, or not yet?

it probably takes a few days to get approved

@raphaelheinz
Copy link

I have submitted the plugin to the Chrome web store. It still needs to get approved. Should be available soon. I will add the link to my repository as soon it is available.

@aystream
Copy link
Contributor

aystream commented Dec 1, 2023

@raphaelheinz I created a new fix in this repository https://github.com/raphaelheinz/LeetHub-3.0 here raphaelheinz/LeetHub-3.0#1, because now extension does not work without sending correct submissionId field

@raphaelheinz
Copy link

Great work @aystream! Thank you very much, I will update my submission

@raphaelheinz
Copy link

Finally I am happy to announce that Google approved Leetcode-3.0. It is available in Chrome Web Store from now on. Please check this repository and don’t forget to star so that you stay updated:

https://github.com/raphaelheinz/LeetHub-3.0

@zaber04
Copy link

zaber04 commented Dec 10, 2023

Not working for me even with old UI.

Also, of possible, please implement for new UI.

@aystream
Copy link
Contributor

Not working for me even with old UI.

Also, of possible, please implement for new UI.

Look at here https://github.com/raphaelheinz/LeetHub-3.0 , https://chromewebstore.google.com/u/1/detail/leethub-v3/kdkgpjpenaeoodajljkflmlnkoihkmda

@rkmiller131
Copy link

The extension still isn't working for me either, since Nov 7, 2023 (so almost 2 months) :(

arunbhardwaj pushed a commit that referenced this issue Feb 19, 2024
* Fix detection of LeetCode V2 using improved document query logic

Enhanced the function isLeetCodeV2 to more accurately determine if the current page is a version of LeetCode. The function now checks for the presence of specific root elements and body classes that indicate whether the page is using Chakra UI light or dark themes, as well as the presence of the "__next" root element. This ensures a more reliable and precise detection of LeetCode's version and UI themes, improving the overall functionality of the script.

Issue: #51

* Fixed submissionId for send solve
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.