Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detection of LeetCode V2 using improved document query logic #52

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

aystream
Copy link
Contributor

Enhanced the function isLeetCodeV2 to more accurately determine if the current page is a version of LeetCode. The function now checks for the presence of specific root elements and body classes that indicate whether the page is using Chakra UI light or dark themes, as well as the presence of the "__next" root element. This ensures a more reliable and precise detection of LeetCode's version and UI themes, improving the overall functionality of the script.

Issue: #51

Enhanced the function isLeetCodeV2 to more accurately determine if the current page is a version of LeetCode. The function now checks for the presence of specific root elements and body classes that indicate whether the page is using Chakra UI light or dark themes, as well as the presence of the "__next" root element. This ensures a more reliable and precise detection of LeetCode's version and UI themes, improving the overall functionality of the script.

Issue: QasimWani#51
@hovanhoa
Copy link

it worked for me. Thank you, @aystream !

Copy link

@raphaelheinz raphaelheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can also confirm this works on my local machine. @arunbhardwaj could you please merge?

@abhinav7sinha
Copy link

@arunbhardwaj can you pls merge?

aystream added a commit to aystream/LeetHub-3.0 that referenced this pull request Dec 1, 2023
Fixed submissionId for send solution, also a bit more from arunbhardwaj/LeetHub-2.0#52 in this pull request.
@sidhant-khamankar
Copy link

sidhant-khamankar commented Dec 12, 2023

Is the owner alive or somebody has created leethub3 extension

@raphaelheinz
Copy link

Is the owner alive or somebody has created kleethub3 extension

@sidhant-khamankar I have created Leethub-3.0 because owner is not responding. Leethub-3.0 is working with the new "dynamic" UI. Please check https://github.com/raphaelheinz/LeetHub-3.0/

@sidhant-khamankar
Copy link

ok thanks

@arunbhardwaj arunbhardwaj merged commit f082077 into arunbhardwaj:main Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants