Fix scripts #80
Merged
Fix scripts #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfitz
approved these changes
Apr 29, 2021
There was a problem hiding this comment.
Looks good. I will pick up https://arupdigital.atlassian.net/browse/LAB-1185 at some point soon, unless you want to do that yourself. I'll have a think about what to do about the Google Maps API key - maybe we can monkey patch or mock that in some way in a smoke test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes broken scripts post #73 as was done for the simplification script here: #79
It would be awesome to have automated tests for these scripts: LAB-1185 records that. I included example invocation for the scripts in that card (because I had to run them post fixing to check they work :D)
There is only one issue with the
send_google_directions_requests_for_network.pywhich will not work properly unless we give it an api key. And I'm not sure how to fake it :D