Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loo_pit for discrete data #1500

Merged
merged 2 commits into from
Jan 16, 2021
Merged

loo_pit for discrete data #1500

merged 2 commits into from
Jan 16, 2021

Conversation

aloctavodia
Copy link
Contributor

@aloctavodia aloctavodia commented Jan 15, 2021

We recently introducing a smoothing step for discrete data in plot_pbv, this does the same but for loo_pit. See example below. I am omitting plot from plot_pbv, because they were part of a previous PR.

  • Follows official PR format
  • Includes a sample plot to visually illustrate the changes (only for plot-related functions)
  • New features are properly documented (with an example if appropriate)?
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

binomial well-calibrated old
binomial_good_old

binomial well-calibrated new
binomial_good_new

binomial bad-calibrated old
binomial_bad_old

binomial bad-calibrated new
binomial_bad_new

Poisson well-calibrated old
poisson_good_old

Poisson well-calibrated new
poisson_good_new

poisson bad-calibrated old
poisson_bad_old

poisson bad-calibrated new
poisson_bad_new

@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #1500 (213651f) into master (2d202de) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1500      +/-   ##
==========================================
- Coverage   91.97%   91.91%   -0.07%     
==========================================
  Files         105      105              
  Lines       11239    11251      +12     
==========================================
+ Hits        10337    10341       +4     
- Misses        902      910       +8     
Impacted Files Coverage Δ
arviz/plots/backends/bokeh/bpvplot.py 82.35% <100.00%> (-0.83%) ⬇️
arviz/plots/backends/matplotlib/bpvplot.py 82.07% <100.00%> (-0.81%) ⬇️
arviz/stats/stats.py 96.12% <100.00%> (-0.29%) ⬇️
arviz/stats/stats_utils.py 96.71% <100.00%> (+0.10%) ⬆️
arviz/wrappers/base.py 17.54% <0.00%> (-3.61%) ⬇️
arviz/data/io_pymc3.py 92.19% <0.00%> (-0.25%) ⬇️
arviz/data/base.py 97.70% <0.00%> (ø)
arviz/data/io_json.py 66.66% <0.00%> (ø)
arviz/data/io_pystan.py 96.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d202de...213651f. Read the comment docs.

@aloctavodia aloctavodia merged commit fddd7f0 into master Jan 16, 2021
@aloctavodia aloctavodia deleted the discrete__pit branch January 16, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants