Update rename_dict on io_pymc3.py converter to follow schema convention #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @OriolAbril |
OriolAbril
reviewed
Feb 12, 2021
CHANGELOG.md
Outdated
| @@ -8,6 +8,7 @@ | |||
| ### Maintenance and fixes | |||
| * Updated `from_cmdstan` and `from_numpyro` converter to follow schema convention ([1541](https://github.com/arviz-devs/arviz/pull/1541) and [1525](https://github.com/arviz-devs/arviz/pull/1525)) | |||
| * Fix calculation of mode as point estimate ([1552](https://github.com/arviz-devs/arviz/pull/1552)) | |||
| * Updated `io_pymc3.py` rename dict to follow schema convention([1555](https://github.com/arviz-devs/arviz/pull/1555)) | |||
There was a problem hiding this comment.
Can you add from_pymc3 to the point above about schema convention? I think it will be more concise and easy to read
There was a problem hiding this comment.
@OriolAbril Sir, Changed the log. Please let me know if there is anything else to update.Thank you
OriolAbril
reviewed
Feb 13, 2021
update Changelog.md to have a single bullet point for schema convention fixes Co-authored-by: Oriol Abril-Pla <oriol.abril.pla@gmail.com>
utkarsh-maheshwari
pushed a commit
to utkarsh-maheshwari/arviz
that referenced
this pull request
May 27, 2021
…on (arviz-devs#1555) * Update rename_dict on io_pymc3.py converter to follow schema convention * Updated `io_pymc3.py` rename dict to follow schema convention * Update `io_pymc3.py` rename dict to follow schema convention and update changelog.md * update CHANGELOG.md * Update CHANGELOG.md * Update Maintenance and Fixes in CHANGELOG.md update Changelog.md to have a single bullet point for schema convention fixes Co-authored-by: Oriol Abril-Pla <oriol.abril.pla@gmail.com> Co-authored-by: Oriol Abril-Pla <oriol.abril.pla@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added remaining parameters to the rename_dict. Addresses issue #1514
Checklist