Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rename_dict on io_pymc3.py converter to follow schema convention #1555

Merged
merged 7 commits into from Feb 14, 2021
Merged

Update rename_dict on io_pymc3.py converter to follow schema convention #1555

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d573071
Update rename_dict on io_pymc3.py converter to follow schema convention
madhucharan Feb 12, 2021
1ce90a9
Updated `io_pymc3.py` rename dict to follow schema convention
madhucharan Feb 12, 2021
2047ed5
Update `io_pymc3.py` rename dict to follow schema convention and upda…
madhucharan Feb 12, 2021
8b37bf1
Merge branch 'update-io_pymc3py' of https://github.com/madhucharan/ar…
madhucharan Feb 12, 2021
5d0bd2d
update CHANGELOG.md
madhucharan Feb 12, 2021
1467079
Update CHANGELOG.md
madhucharan Feb 13, 2021
91bf068
Update Maintenance and Fixes in CHANGELOG.md
madhucharan Feb 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -8,6 +8,7 @@
### Maintenance and fixes
* Updated `from_cmdstan` and `from_numpyro` converter to follow schema convention ([1541](https://github.com/arviz-devs/arviz/pull/1541) and [1525](https://github.com/arviz-devs/arviz/pull/1525))
* Fix calculation of mode as point estimate ([1552](https://github.com/arviz-devs/arviz/pull/1552))
* Updated `io_pymc3.py` rename dict to follow schema convention([1555](https://github.com/arviz-devs/arviz/pull/1555))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add from_pymc3 to the point above about schema convention? I think it will be more concise and easy to read

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OriolAbril Sir, Changed the log. Please let me know if there is anything else to update.Thank you


### Deprecation
* Removed Geweke diagnostic ([1545](https://github.com/arviz-devs/arviz/pull/1545))
Expand Down
7 changes: 6 additions & 1 deletion arviz/data/io_pymc3.py
View file
Open in desktop
Expand Up @@ -274,7 +274,12 @@ def posterior_to_xarray(self):
def sample_stats_to_xarray(self):
"""Extract sample_stats from PyMC3 trace."""
data = {}
rename_key = {"model_logp": "lp"}
rename_key = {
"model_logp": "lp",
"mean_tree_accept": "acceptance_rate",
"depth": "tree_depth",
"tree_size": "n_steps",
}
data = {}
data_warmup = {}
for stat in self.trace.stat_names:
Expand Down