Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pairplot example and spacing #214

Merged
merged 1 commit into from
Sep 8, 2018

Conversation

canyon289
Copy link
Member

@canyon289 canyon289 commented Sep 8, 2018

Fixes #212

Example Plots, It's easy enough to change the spacing if someone has a strong preference.

One thing to note is that there's some strange behavior with the y axis label positions. If this is problematic I create an issue.

pairplot_1
pairplot_2
pairplot_3
pairplot_4
pairplot_5
pairplot_6
pairplot_7
pairplot_8

@ahartikainen
Copy link
Contributor

Can we split varname to multiple lines?

Dim first, then coords?

Something like

"\n".join(dim_name, coord1, coord2)

Also, will pairplot fail if gridspec (gs) is defined? Is there indentation error?

@ahartikainen
Copy link
Contributor

Also, should divergent samples have greater contrast to main color?

E.g. a bit lighter color like salmon, lime, yellow?

@aloctavodia
Copy link
Contributor

Splitting varnames to multiple lines would be great.
Default colors should be restricted to the default cycle (C0, C1, etc), as they have been optimized to be colorblind-friendly (C4 is yellow).

@ColCarroll ColCarroll merged commit 378e65a into arviz-devs:master Sep 8, 2018
@ColCarroll
Copy link
Member

Looks nice! We could also add a hexgrid version of this to the examples.

Splitting varnames is a good idea - I think make_label is used uniformly throughout, so it might even easy.

@ahartikainen
Copy link
Contributor

Hex grid might be ok, but 2D KDE even better (with contours). See examples here https://agilescientific.com/blog/2017/12/14/no-more-rainbows

To get a working 2D KDE with fast_kde needs careful settings with limits.

@aloctavodia
Copy link
Contributor

aloctavodia commented Sep 8, 2018

One good thing of hexgrid is that is really fast, we should also have 2D KDE (thus kind will accept 3 options 'scatter', 'hexgrid' and 'kde'). I may have a 2D-fast_kde version somewhere (not sure), I should check... Probably we should have a fast_kde and a separated fast_kde_2d version, in order to not slow down fast_kde.

@ahartikainen
Copy link
Contributor

Yes, separate functions is needed. I have one working function somewhere.

@ahartikainen
Copy link
Contributor

ahartikainen commented Sep 8, 2018

Nope, didn't find it, but basically it is a fork from 1D with specific limit constrains. Faststats has one implementation, but that could fail, if limits are outside min,max of data

@aloctavodia
Copy link
Contributor

OK, don't worry I will send a PR on Monday or Tuesday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants