Skip to content
This repository has been archived by the owner on Mar 18, 2022. It is now read-only.

Operators that perform login redirection don't work #5

Closed
arvvoid opened this issue Jan 28, 2019 · 64 comments
Closed

Operators that perform login redirection don't work #5

arvvoid opened this issue Jan 28, 2019 · 64 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@arvvoid
Copy link
Owner

arvvoid commented Jan 28, 2019

  • Czech Republic: Skylink [REDIRECT LOGIN] [SOLVED CONFIRMED WORKING]

  • Czech Republic: UPC CZ [REDIRECT LOGIN] [SOLVED CONFIRMED WORKING]

  • Polonia: Cyfrowy Polsat [REDIRECT LOGIN] [SOLVED CONFIRMED WORKING]

  • Romania: UPC Romania [REDIRECT LOGIN] [ERROR NOT WORKING]

  • Slovakia: Skylink [REDIRECT LOGIN] [SOLVED CONFIRMED WORKING]

  • Slovakia: UPC CZ [REDIRECT LOGIN] [SOLVED CONFIRMED WORKING]

  • Romania: Telekom Romania (My Account) [REDIRECT LOGIN] [SOLVED CONFIRMED WORKING]
    (NOTE OTHER TELEKOM ROMANIA LOGIN OPTIONS HAVE BEEN ADDED TO HBO GO AND SHOULD WORK)

For a few operators, the login is not performed directly using the hbogo api.
Instead, the user is redirected to the operator website the login is performed there, and then the operator login the user on hbogo and redirect back.
What exactly happens and how, will have to be figured out and then implemented in the add-on for those operators to work.

Impossible for me to fix and test since I don't have access to one of these operators.
If someone using one of the listed above operators want to help fix the issue let me know here.

@arvvoid arvvoid added bug Something isn't working help wanted Extra attention is needed labels Jan 28, 2019
@Bibi40k
Copy link

Bibi40k commented Feb 3, 2019

Hi,
i login using Romania: Telekom Romania [REDIRECT LOGIN], how can i help ?

@arvvoid
Copy link
Owner Author

arvvoid commented Feb 4, 2019

Hello, thanks for the help offer.
Please post a debug log with the latest version, make sure to try to play a video from the add on (https://kodi.wiki/view/Log_file/Easy).
That might be enough to fix it.

If not probably someone with access to one of these operators with programming skills will have to implement it and send a pull request.
The other option is, someone with access to one of these operators lands me an account for a couple of days so i can figure out the login and implement it. (please don't post login info publicly) But i will leave this option as last resort, let's start with debug logs.

It might be necessary to implement a different login procedure for each one of these operators, still not sure until i can see more details.

@arvvoid arvvoid added this to the v.2.0.EU milestone Feb 4, 2019
@arvvoid
Copy link
Owner Author

arvvoid commented Feb 9, 2019

(Yesterday, 13:45)kowalmisiek Wrote:
Does logging in to Poland / POLSAT already work in this version?

Unfortunately, it still does not work for Poland / POLSAT.

This is my kodi.log
https://paste.kodi.tv/toxoqitafi.kodi

@arvvoid
Copy link
Owner Author

arvvoid commented Feb 21, 2019

fireangel 19.02.2019, 19:38 Kodi Forum
I did another log file because the previuos log dont show anything , dont know why

log file https://paste.kodi.tv/aqenukinoz

@arvvoid
Copy link
Owner Author

arvvoid commented Feb 21, 2019

Found a useful implementation here: https://github.com/kszaq/plugin.video.hbogopl , need to be tested. This might solve the problem for * UPC and * Cyfrowy Polsat and give hints to solve the rest as well.

arvvoid added a commit that referenced this issue Feb 22, 2019
arvvoid added a commit that referenced this issue Feb 23, 2019
@arvvoid arvvoid self-assigned this Feb 24, 2019
arvvoid added a commit that referenced this issue Feb 24, 2019
arvvoid added a commit that referenced this issue Feb 24, 2019
@arvvoid
Copy link
Owner Author

arvvoid commented Feb 24, 2019

Please test version: plugin.video.hbogoeu-2.0.4~beta12.zip and report results with full debug log

@arvvoid
Copy link
Owner Author

arvvoid commented Feb 26, 2019

Confirmed working for * Polonia: Cyfrowy Polsat [REDIRECT LOGIN].

Waiting for feedback for other providers. If no feedback for 2 weeks going to close this. Can be reopened if a problem is found.

@arvvoid
Copy link
Owner Author

arvvoid commented Feb 28, 2019

fireangel Wrote:
Hi.
I instaled the lates plugin v.2.0.5-beta16 , and after i log in with user and pasw i get " HBO GO EU Error : check the log for more information "
Here are the log : deqacawoka (paste)

confirmed still not working for UPC Romania

@cyberreality
Copy link

hi there !
i'm using Czech Republic: Skylink [REDIRECT LOGIN] and does not work, see my log: https://paste.kodi.tv/oviyezesiy.kodi
thanks

@alpa4r
Copy link

alpa4r commented Mar 27, 2019

Hello,
Romania: UPC Romania does not work, how can i help?

@arvvoid
Copy link
Owner Author

arvvoid commented Mar 27, 2019

Hello,
not having access to those operators is impossible for me to test and figure out the response given by the operator on successful login and extract the data necessary to complete the login procedure.
Found and implemented a working solution for Cyfrowy Polsat hoped it would be the same for the rest, and for the most part, it is, but there are some differences and some things have to be handled differently.
I have some ideas, will make a version that provides me a little more detail in debug log and hopefully that will help me solve the problem for the remaining 5 operators.

@cyberreality
Copy link

@arvvoid so please check my kodi log above, its for Skylink Czech, one can see it performs redirection to
OPERATOR REDIRECT: https://hbogo.skylink.cz/goauthenticate.aspx?client_id=HBO&redirect_uri=......
so maybe easy to fix

@arvvoid
Copy link
Owner Author

arvvoid commented Mar 28, 2019

@cyberreality I checked your log. Read my answer above, it's clear to me where and why it fails but I will have to extend what gets written to the debug log in hope of having enough info to fix it.
It's not a complicated fix, the complicated and slow part is getting the info necessary to fix it not having access to those operators. I have to write a slightly different login procedure for each one of those.

@alpa4r @cyberreality When I release the next beta version (probably next week) try again and send a debug log here. Hopefully will have enough info then to fix it.

CURRENT STATUS IS THIS:

  • Czech Republic: Skylink [REDIRECT LOGIN] [ERROR CONFIRMED STILL NOT WORKING]
  • Czech Republic: UPC CZ [REDIRECT LOGIN] [ERROR CONFIRMED STILL NOT WORKING]
  • Polonia: Cyfrowy Polsat [REDIRECT LOGIN] [SOLVED CONFIRMED WORKING]
  • Romania: Telekom Romania [REDIRECT LOGIN] [STATUS UNKOWN]
  • Romania: UPC Romania [REDIRECT LOGIN] [ERROR CONFIRMED STILL NOT WORKING]
  • Romania: Vodafone Romania 4GTV+ [REDIRECT LOGIN] [STATUS UNKOWN]
  • Slovakia: Skylink [REDIRECT LOGIN] [ERROR CONFIRMED STILL NOT WORKING]
  • Slovakia: UPC CZ [REDIRECT LOGIN] [ERROR CONFIRMED STILL NOT WORKING]

All other operators perform login directly on Hbo go and work fine.

@cyberreality Does a local CZ version of the add-on exist where Skylink Czech has already been figured out and implemented and works correctly?

@cyberreality
Copy link

@cyberreality Does a local CZ version of the add-on exist where Skylink Czech has already been figured out and implemented and works correctly?

yope, there is a CZ version of HBOGO addon but only direct login works, no redirect at the moment ...
latest version attached:
plugin.video.hbogocz-0.7.9a.zip

@TheImmortalOne
Copy link

For Romania - Telekom Romania, the redirect login is failing: http://paste.kodi.tv/cusiboluza

@arvvoid
Copy link
Owner Author

arvvoid commented Apr 12, 2019

@TheImmortalOne tnx for the log, for now, I'm stuck with this, each of the operators with login redirect requires a slightly different implementation but not having access to those is difficult to test an figure out what has to be done. Ideally a local developer with access to the operator in question has to figure it out an implement it, and send a pull request.
Or someone has to provide me with all HTTP/S Requests and Responses sent between the Web browser and the Web server during the login procedure to the operator in question,

@TheImmortalOne
Copy link

@arvvoid, if you can link me a basic how-to for providing 'all the https requests and responses' (i suspect somehow from chrome's dev tools?), I can definitely help with that.

@ursan2003
Copy link

@arvvoid if you need the account hbo upc romania to try fix the login please leave a message
.Thanks

@splichy
Copy link
Contributor

splichy commented Dec 9, 2019

Hi @arvvoid you had wrong login redirect URL see #84

@arvvoid
Copy link
Owner Author

arvvoid commented Dec 10, 2019

@splichy tnx for your contribution, going to merge your PR

@arvvoid
Copy link
Owner Author

arvvoid commented Dec 10, 2019

@all-contributors please add @splichy for ideas, code

@allcontributors
Copy link
Contributor

@arvvoid

I've put up a pull request to add @splichy! 🎉

@arvvoid
Copy link
Owner Author

arvvoid commented Dec 10, 2019

Now just need confirmation this work for UPC CZ and SK: https://github.com/arvvoid/plugin.video.hbogoeu/archive/UPC_cz_sk_fix.zip
@xjoska @chozze @splichy

Also need confirmation if it works for UPC Romania: https://github.com/arvvoid/plugin.video.hbogoeu/archive/UPC_cz_sk_fix.zip
@alpa4r @ursan2003 @rsn13

Waiting on this to merge and push the next stable release

@chozze
Copy link

chozze commented Dec 10, 2019

Bravo @arvvoid, I'm happy to confirm it works for UPC CZ!

@chozze
Copy link

chozze commented Dec 10, 2019

btw just FYI, that UPC was bought by Vodafone so we can expect to change the login redirect URLs to change in near future once again.

@arvvoid
Copy link
Owner Author

arvvoid commented Dec 10, 2019

@chozze Vodafone at least for other countries uses standard 3th party operator login. But changes can happen with no notice at any time in any segment. Hopefully, we will be able to sort out future changes quickly.

@arvvoid arvvoid modified the milestones: v.3.0.EU, v.2.0.EU, V.2.1.EU Dec 10, 2019
@splichy
Copy link
Contributor

splichy commented Dec 10, 2019

At least for UPC SK login will change after LGI finish transition(UPC SK wasn't part of deal).
Not sure what will happen with UPC CZ but there is chance that will remain unchanged as it uses upc.cz. domain.
We will see in a year

@splichy
Copy link
Contributor

splichy commented Dec 10, 2019

I have created pull request to add your addon into kodi-czsk repository
kodi-czsk/repository#54

@arvvoid
Copy link
Owner Author

arvvoid commented Dec 10, 2019

@splichy what version will be added there? pulling directly from master is not a good idea. I already maintain a repository with stable releases (https://github.com/arvvoid/repository.arvvoid) and plan to send the add-on to the official repo in the near future. So I would like to keep consistency with the versions in the repositories I would prefer to have only stable releases in repository.

I can create a branch for the czsk repository and keep there stable releases ready for release with no unnecessary additional files. Then the repository should pull releases from there, not from master if possible.

@arvvoid
Copy link
Owner Author

arvvoid commented Dec 10, 2019

@splichy here you go clean branch stable release ready https://github.com/arvvoid/plugin.video.hbogoeu/tree/repo_ready_stable each stable release is a single commit will get updated with each stable release a stable release with this fixes will be available in max few days

@splichy
Copy link
Contributor

splichy commented Dec 10, 2019

kodi-czsk works on principe: when version in addon.xml changes in master than run: update submodule... and publish new version.
Especially for CZ & SK users this is one of the best sources of addons - it's much simpler to add just single repo than searching over internet and adding dozens repos
IMHO it's good practice to keep development in branches and latest stable in master

right now kodi-czsk probably don't support updating from different branches
snippet from release.sh:

# taken grom xbmc-czech-sf.net
TOOLS=$(dirname "$0")"/tools"


BUILD_DIR=tmp
PUBLISH_DIR=repo
mkdir -p ${BUILD_DIR}

echo "Updating addon submodules"
git submodule init
git submodule update
git submodule foreach git pull origin master

see https://github.com/kodi-czsk/repository

@arvvoid
Copy link
Owner Author

arvvoid commented Dec 10, 2019

@splichy the master branch is generally stable and functional but can contain files not really necessary to be included in the release zip (the add on will still work but unnecessary files, test scripts, github configurations, possibly build scripts, CI configs, gitignore lists ecc will get included as well)

@splichy
Copy link
Contributor

splichy commented Dec 10, 2019

according to release.sh precompiled, swap and hidden files are excluded:
zip -FS -q -r "$package" "$dirname" -x "*.py[oc] *.sw[onp]" ".*"
So prepending . before everything you don't wan't to be packed to final zip should be enough

@splichy
Copy link
Contributor

splichy commented Dec 10, 2019

^^^ sorry ".*" is not part of -x argument
But I think that excludes in release script can be extended

@arvvoid
Copy link
Owner Author

arvvoid commented Dec 10, 2019

@splichy if you want to include it in the CZ repo is fine, just some unneeded stuff will get in the ZIP with this system. After this release is ready (2.1.0), I will submit to the official Kodi repo.

@splichy
Copy link
Contributor

splichy commented Dec 10, 2019 via email

@arvvoid
Copy link
Owner Author

arvvoid commented Dec 11, 2019

Hello, we went a little offtopic with the last few posts, is there someone using UPC Romania able to test if by any chance the last PR fixed the login?
@alpa4r @ursan2003 @rsn13

test current master: https://github.com/arvvoid/plugin.video.hbogoeu/archive/master.zip

@arvvoid arvvoid closed this as completed Dec 17, 2019
@arvvoid arvvoid unpinned this issue Dec 17, 2019
@cdps82
Copy link

cdps82 commented Mar 27, 2020

Hi, could you please also check the login for Czech Republic/sledovanitv.cz s.r.o.? When I login, everything works just great, but only as long as I do the first restart of Kodi. Then I get a wrong credentials error message. What helps is to Log-out (settings reset) and then loging in over again.

Thank you all for your great job!

PS: I can send you the credentials for testing purposes upon your request.

@arvvoid
Copy link
Owner Author

arvvoid commented Mar 27, 2020

Hello @cdps82 tnx.
What you describe is unrelated to this issue, that sounds more like a problem with your device/Kodi installation.
This issue is closed, not a proper place to bring new unrelated issues. Please open a proper issue following all the rules, with a proper full debug log otherwise I can't help you.

Repository owner locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests